From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Salah Triki <salah.triki@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: temperature: tsys01: fix broken PROM checksum validation
Date: Tue, 28 Apr 2026 18:49:56 +0300 [thread overview]
Message-ID: <afDXJLGYzF8uwaj5@ashevche-desk.local> (raw)
In-Reply-To: <20260428152239.66213-1-salah.triki@gmail.com>
On Tue, Apr 28, 2026 at 04:22:39PM +0100, Salah Triki wrote:
> The CRC check function was incorrectly using only the first word of the
> PROM (n_prom[0]) instead of iterating through all words. This caused
> the driver to fail probing on most devices due to incorrect checksum
> calculation.
>
> - Fix loop to use the correct index n_prom[cnt].
> - Ensure all bytes are summed as per the datasheet specification.
...
> u8 sum = 0;
>
> for (cnt = 0; cnt < TSYS01_PROM_WORDS_NB; cnt++)
> - sum += ((n_prom[0] >> 8) + (n_prom[0] & 0xFF));
> + sum += ((n_prom[cnt] >> 8) + (n_prom[cnt] & 0xFF));
>
> return (sum == 0);
This change makes more questions than answers. How had it been tested,
if tested at all? (This question is to before and to after, the commit
message is also unclear about what datasheet says or the real field
testing gives.)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-28 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 15:22 [PATCH] iio: temperature: tsys01: fix broken PROM checksum validation Salah Triki
2026-04-28 15:49 ` Andy Shevchenko [this message]
2026-04-29 9:33 ` Jonathan Cameron
2026-05-05 7:01 ` Salah Triki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afDXJLGYzF8uwaj5@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=salah.triki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox