From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: "Rafael G. Dias" <rafael.guimaraes.dias@usp.br>,
jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, Felipe Khoury Dayoub <felipedayoub@usp.br>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: light: stk3310: update includes to match IWYU
Date: Wed, 29 Apr 2026 22:39:37 +0300 [thread overview]
Message-ID: <afJeeREcy8d-Tghm@ashevche-desk.local> (raw)
In-Reply-To: <CALoEA-wd9jo_bPCGF0GqLH9SX7vWsCN7oyvkN3Q86R0F=WTjog@mail.gmail.com>
On Tue, Apr 28, 2026 at 04:33:17PM +0200, Joshua Crofts wrote:
> On Tue, 28 Apr 2026 at 16:13, Rafael G. Dias
> <rafael.guimaraes.dias@usp.br> wrote:
...
> > +#include <linux/interrupt.h>
> > +#include <linux/irqreturn.h>
This is implied by interrupt.h
> > +#include <linux/kconfig.h>
>
> I don't think you need this.
Definitely. This actually should be removed from any driver using it. This
header is so special (hint: it's ALWAYS included by a Kbuild system).
...
> > +#include <linux/stddef.h>
>
> You don't need to include this.
Depends, but since we have types.h, this is not needed.
> > +#include <linux/sysfs.h>
>
> Remove this too, the driver already uses the linux/iio/sysfs.h
> variant.
Depends. If we use something from linux/sysfs.h it's still needed.
> > +#include <linux/types.h>
(left for a context for the above)
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-04-29 19:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 13:41 [PATCH] iio: light: stk3310: update includes to match IWYU Rafael G. Dias
2026-04-28 14:33 ` Joshua Crofts
2026-04-28 15:05 ` Jonathan Cameron
2026-04-29 19:39 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afJeeREcy8d-Tghm@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=felipedayoub@usp.br \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=rafael.guimaraes.dias@usp.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox