From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23722194A6C for ; Wed, 29 Apr 2026 19:49:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777492198; cv=none; b=XwUyqAjaIkon3nxMmJuFaklxAQ64CsB+VxgbSmOH09fR85yWz+0OTxrLbZuLCY6Rgs0dF6wg7UOcWesUDwouiHSEAB3XfSy0R43j3SshlASNbMCATBWoEIaqDEK8j4wbhKEvAZga/s/QkE7uHV092u9xMqNllTn6AuiXV3Hz6I4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777492198; c=relaxed/simple; bh=+QGpDVkNjr4HWGcQEc69vi5MRqm3FSLulek/jk+bbr4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=akWzP1Pn2h5HlDYqGtK7GsUOlj+QKfoXw45OG+Uv2cadD6VhExn2OZGChRflIs4y3jh/WNz25frInW8EBIMfjSEo7llP8zye57y9VXt+H65x3hyiLmRSdnMqUfDKngS8Qkt1m3nqKbTConKdNrfvSTRuONUEIIlFA6unopN9CVc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=QxLUVcQU; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="QxLUVcQU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777492197; x=1809028197; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+QGpDVkNjr4HWGcQEc69vi5MRqm3FSLulek/jk+bbr4=; b=QxLUVcQUgJT3UqteLU7ClOw5mJT1wgq0vTNm7MGTkYKB3pLd56Xhk3ZU MVC9BEc1lOLEoA1BfAsHeZfxPb5nBe6qwz3mmSAlxTi1DgRduRYsYhPOG AV4Gt9qBxziFqYtYSK6k2Sq+FdeiVyHT5q2iulwRDBnSDETnAWEYXulkX XqdikIph1Msk1pDXp6DnEdAv1caJ0A0WX+ztw0jxOghyeiQTLf/b7W274 7FqYb+YXxWekbd1xyT3UDG3Wl61bFV4d8GfuFir/EcL8YeW10pNajKE2u OsDt5isEw5nNdaZB5cGGa08Wm0q46QVaaqEFP9MbIBZwJlfXBLtY6hTf4 g==; X-CSE-ConnectionGUID: ydlk4jHBSdKpK64wbqo3Lg== X-CSE-MsgGUID: DP4+tPaNTQ+ZvPKukN7cTg== X-IronPort-AV: E=McAfee;i="6800,10657,11771"; a="103888846" X-IronPort-AV: E=Sophos;i="6.23,206,1770624000"; d="scan'208";a="103888846" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2026 12:49:56 -0700 X-CSE-ConnectionGUID: Uu5lbD+ETPqlboOTEezHKw== X-CSE-MsgGUID: japUiqltSbWOi4wniSadzw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,206,1770624000"; d="scan'208";a="236138725" Received: from ettammin-mobl2.ger.corp.intel.com (HELO localhost) ([10.245.245.141]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2026 12:49:54 -0700 Date: Wed, 29 Apr 2026 22:49:52 +0300 From: Andy Shevchenko To: "Rafael G. Dias" Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, joshua.crofts1@gmail.com, Felipe Khoury Dayoub Subject: Re: [PATCH v2 2/2] iio: light: stk3310: Update includes to match IWYU Message-ID: References: <20260428161339.1187956-1-rafael.guimaraes.dias@usp.br> <20260428161339.1187956-2-rafael.guimaraes.dias@usp.br> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260428161339.1187956-2-rafael.guimaraes.dias@usp.br> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Apr 28, 2026 at 01:13:39PM -0300, Rafael G. Dias wrote: > Clean up the included headers in stk3310.c according to the > Include-What-You-Use (IWYU) tool. Remove the generic > header and add explicit dependencies to improve compilation accuracy. ... > +#include > +#include > +#include In most cases we assume errno (but strictly speaking it's asm/errno) is included by err.h. Double check if there are no codes >= 512 are in use in the driver. If no, drop errno.h. > #include > #include > -#include > +#include Implied by interrupt.h. > #include > #include > +#include > +#include > +#include > #include > +#include > +#include -- With Best Regards, Andy Shevchenko