Re: [PATCH v3] iio: gyro: adxrs290: Use guard(mutex) in lieu of manual lock+unlock

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Wed, Apr 29, 2026 at 04:51:05PM -0300, Guilherme Dias wrote:
> Use guard(mutex) to automatically release the lock on scope exit,
> simplifying the error handling path and removing the need for
> explicit unlock and goto-based cleanup.

...

> +	do {
> +		guard(mutex)(&st->lock);
>  
> -	/* exercise a bulk data capture starting from reg DATAX0... */
> -	ret = spi_write_then_read(st->spi, &tx, sizeof(tx), st->buffer.channels,
> -				  sizeof(st->buffer.channels));
> -	if (ret < 0)
> -		goto out_unlock_notify;
> +		/* exercise a bulk data capture starting from reg DATAX0... */
> +		ret = spi_write_then_read(st->spi, &tx, sizeof(tx), st->buffer.channels,
> +						sizeof(st->buffer.channels));

Fix the indentation. The (starting) column for the parameters should be
the same. Also the first one goes over 80 limit, wrap that and it's actually
gets better as the split will become more logical.

		ret = spi_write_then_read(st->spi, &tx, sizeof(tx),
					  st->buffer.channels,
					  sizeof(st->buffer.channels));

> +		if (ret < 0)
> +			break;
>  
> -	iio_push_to_buffers_with_timestamp(indio_dev, &st->buffer,
> -					   pf->timestamp);
> +		iio_push_to_buffers_with_timestamp(indio_dev, &st->buffer,
> +						pf->timestamp);
> +	} while (0);

-- 
With Best Regards,
Andy Shevchenko