From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Pedro Barletta Gennari <pedro.pbg@usp.br>
Cc: andy@kernel.org, dlechner@baylibre.com, jic23@kernel.org,
nuno.sa@analog.com, linux-iio@vger.kernel.org
Subject: Re: [PATCH v3 0/2] iio: light: iqs621-als: use lock guards and prefer early error handling
Date: Wed, 29 Apr 2026 23:01:34 +0300 [thread overview]
Message-ID: <afJjnq4z76XFaEBF@ashevche-desk.local> (raw)
In-Reply-To: <20260429013640.26870-1-pedro.pbg@usp.br>
On Tue, Apr 28, 2026 at 10:29:53PM -0300, Pedro Barletta Gennari wrote:
> Use guard(mutex)() for handling mutex lock instead of manually
> locking and unlocking the mutex and flip 'if (!ret)' to 'if (ret)'
> to handle errors early in drivers/iio/light/iqs621-als.c
>
> Patch 2 depends on patch 1
Both LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-29 20:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 1:29 [PATCH v3 0/2] iio: light: iqs621-als: use lock guards and prefer early error handling Pedro Barletta Gennari
2026-04-29 1:29 ` [PATCH v3 1/2] iio: light: iqs621-als: use lock guards Pedro Barletta Gennari
2026-04-29 1:29 ` [PATCH v3 2/2] iio: light: iqs621-als: prefer early error handling over if (!ret) Pedro Barletta Gennari
2026-04-29 20:01 ` Andy Shevchenko [this message]
2026-05-05 16:35 ` [PATCH v3 0/2] iio: light: iqs621-als: use lock guards and prefer early error handling Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afJjnq4z76XFaEBF@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=pedro.pbg@usp.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox