Re: [PATCH] iio: frequency: adf4377: replace mutex_lock/unlock with guard and scoped_guard

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Wed, Apr 29, 2026 at 05:23:04PM -0300, Educg550 wrote:

> Replace manual mutex_lock()/mutex_unlock() calls with guard(mutex) and
> scoped_guard(mutex) from cleanup.h.

...

>  static int adf4377_freq_change(struct notifier_block *nb, unsigned long action, void *data)
>  {
>  	struct adf4377_state *st = container_of(nb, struct adf4377_state, nb);
> -	int ret;
>  
>  	if (action == POST_RATE_CHANGE) {
> -		mutex_lock(&st->lock);
> -		ret = notifier_from_errno(adf4377_init(st));
> -		mutex_unlock(&st->lock);
> -		return ret;
> +		scoped_guard(mutex, &st->lock)
> +			return notifier_from_errno(adf4377_init(st));

The scoped_guard() makes more sense when we have some code in between before
returning, here the guard()() fits much better.

Alternatively:

		scoped_guard(mutex, &st->lock)
			ret = adf4377_init(st);
		return notifier_from_errno(ret);

>  	}
>  
>  	return NOTIFY_OK;

-- 
With Best Regards,
Andy Shevchenko