From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A9A634320E for ; Mon, 18 Aug 2025 18:59:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755543579; cv=none; b=lI97B0zro4HNb/dNi01tBHv/PHhtIxerSg96rw9K7q7xk8LUemb07MYzIhQcpFChO7lMNxk7/Z7A5qu0cjskc/O1Hk2RAFUFrBnrdfgb1PncHX3orwVkA+y1mSBburCrPC9ZbdP0xxS1nPVoQmIUkkIJG75v9UVWZu+gulEoZnw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755543579; c=relaxed/simple; bh=TKCCw8hxZx4LVNHBY9YD1eV99l6dol3ZQ7qCTmBpYeE=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=dMWcvkaHQoTAAOrJpg1QDjVt2N8OGAh+G6RERZzCHwu24HFM4P9rFGfVnY5oJaf/X/B5xwOW70V3VytqX69Y7ZCKRxRkYaxBUKvy8a533VpWYsNNp8O2IhSj5NVytEE5SV1P/v8UdLuGwSgLIHHbkslY+GE0gHaZRSjc5SNCNPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=E2Akqu2k; arc=none smtp.client-ip=209.85.160.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="E2Akqu2k" Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-30ccebab736so3851801fac.3 for ; Mon, 18 Aug 2025 11:59:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1755543577; x=1756148377; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=GlFt92LPhKKS01GxFk+3B9rLETOli+lTNFbApZNS7uE=; b=E2Akqu2kdKqk9LByI5Mu41SCz+cFCC9vdDmIV7ZMa9cMEfRd7Ix8N3ZynKHiPGgwZe fN341G57r1thuKx2q9L1/yB0o070LUdlqWJZ8jjjvDkgVCaWNeTjkoJ1iQ9k2DqNllQ3 zGbzfpS+CzQoe5L/kHaCPyGE2zIXBRmf+Zl4JJucAXd8t4W4ddGmtA/VWEfQ2tXvIi+D 6ZUvlgfBUCLVFXx/w1O8dfsODQYa/w9ysfGFFkG48nCQMx3EkQJx+F5FE6nRN4J+DL7K XcH2ENmeWLUoJ7r2mOW7I/eDKaGqfeZDaOViSnYyRgvHjhCuEoq3uDvGjB/h6gYZ/vYS WPoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755543577; x=1756148377; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GlFt92LPhKKS01GxFk+3B9rLETOli+lTNFbApZNS7uE=; b=k/YV6Nj1c92J7zJyl8oID1eZvlr+EiNdeVAtJVAL4Gi9HVuiub91mLWeRVbQ5JnRXt L0QirijAJr4Bff7M3mlJkyCR48Uf6BvD+FfBews2woPKcTflFcFyj0eBrFsS6V4hsM0M rBL2f5yAdkswo1z6UaFy2eCj85F87bTTeytgZejbyLCjLUss0xxIdjtZ0vPl5Gb7rN7k KT1Q5N6nBXG35704PjzbZoKddRTaGLIdF3ovqH4cMTkI5vL/nWnJlJ6JGU/9j3KUCbCX 0PQ+qWmantId//AQPh39pcN+Z6esgrI2UngqGn2cuPDMcYYqfQtMAsFr2fcLaDHc5QZp KndA== X-Forwarded-Encrypted: i=1; AJvYcCXBe/c/0cCf/MRWefBC3BAhTEnHtnkVQYp8briHUcrkg0q0/i5sNQ/4a+Hgv+MuU9l6XrkzEGrMFmk=@vger.kernel.org X-Gm-Message-State: AOJu0YyUQsaB1FGnBY6igoTF680Ey0M5JPwuUUFqyn7wPJY+Y1eEdly1 zwnmo26Eq1CRiOn6n84YORytVacGwYyYGzJ0azFf7NpCzbI1J0y8Qdyxqua2v/ueqto= X-Gm-Gg: ASbGncsjk+ap6wzml9qPYcCGPol0Y0qN4/LYvroLX9QH1NH6qlPDsDHHui/stzArdKG D4tdU1AsThWXNAaAw+9Vw/QuWD6VED1Lv6U0ne8lkQxcEsLuBerT+LWpqXRa/31I59Q6feawznf i93m7qb9xZJlIiiN1JMzWLtj3RlVxx3TFJNV+gZpM4EgkBDtXg48tgNi6BDk2waotrhczyq4Zes /l2f9dhHa5C/2yinemKpW687rwcueDgnakRRfKwDMOe0tY9cuEE17G6tO416NPXM3MTF9N7lotl lp3CKp3imzkQKwPXtWb49bLrQproIC0MMHyMNEEAe3sVjzLR58iE0FKRrTtQdcdiV6pXvmLVt7p 68P7GoXZRzZ3EilwGEd3acTS5lgiMAmcJMPkMT5ul7TkblvPXmKU/Xtg/fVNQRDKLtNeC66tQTw A= X-Google-Smtp-Source: AGHT+IHn7xbYfVCjCn3B+LxjKaU8SE92tJikPGsdCOYbX/YUHwX3Y5pn9k9bm7xFGgU57eO/UzXIiQ== X-Received: by 2002:a05:6871:29d:b0:2d6:2a40:fb9d with SMTP id 586e51a60fabf-310be68e4d7mr5826676fac.28.1755543576697; Mon, 18 Aug 2025 11:59:36 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:ee1a:f057:94fa:9a73? ([2600:8803:e7e4:1d00:ee1a:f057:94fa:9a73]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-310abbf8442sm2819512fac.31.2025.08.18.11.59.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Aug 2025 11:59:35 -0700 (PDT) Message-ID: Date: Mon, 18 Aug 2025 13:59:34 -0500 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 5/5] iio: mcp9600: Add support for IIR filter To: Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250818035953.35216-1-bcollins@kernel.org> <20250818035953.35216-6-bcollins@kernel.org> <20250818191539.69e1882a@jic23-huawei> <2025081814-grumpy-prawn-ef1a0e@boujee-and-buff> Content-Language: en-US From: David Lechner In-Reply-To: <2025081814-grumpy-prawn-ef1a0e@boujee-and-buff> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/18/25 1:47 PM, Ben Collins wrote: > On Mon, Aug 18, 2025 at 07:15:39PM -0500, Jonathan Cameron wrote: >> On Sun, 17 Aug 2025 23:59:53 -0400 >> Ben Collins wrote: >> >>> From: Ben Collins >>> >>> MCP9600 supports an IIR filter with 7 levels. Add IIR attribute >>> to allow get/set of this value. >>> >>> Use a filter_type[none, ema] for enabling the IIR filter. >> Hi Ben, >> >> A few comments inline. You also need to send an additional patch to update >> the filter_type docs in Documentation/ABI/testing/sysfs-bus-iio > > Hi Jonathan, > > I just sent a v6 because I was getting too many comments on the > dt-bindings patch. Actually, folks will be happier if you slow down a bit. General advice is only submit one revision per week since some people only have time to review once per week. If you are really in a hurry, there should still be no more than one revision per day. Otherwise, it is really hard for reviewers to keep up. As it is, the subject of what I presume is v6 still says v5 in the cover letter and doesn't have a version in the rest of the patches. And there are still some of the same problems with the devicetree patch that didn't get addressed. If you slow down a bit and take a little more care before firing off the next one, it will likely be better received. > > I'll send a v7 with these changes and anything else that comes up. >