From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: "João Fernandes" <joaovictor.fernandes@usp.br>,
jean-baptiste.maneyrol@tdk.com, jic23@kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
gcotavio@usp.br, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: imu: inv_icm42600: refactor accel/gyro configuration paths
Date: Mon, 4 May 2026 17:17:04 +0300 [thread overview]
Message-ID: <afiqYP8PrVpGs0Bq@ashevche-desk.local> (raw)
In-Reply-To: <CALoEA-x7kEXYNzGWJ-6dxJzBoShnx+26Y-VhDP4wFz99VsxiWQ@mail.gmail.com>
On Sun, May 03, 2026 at 11:13:39AM +0200, Joshua Crofts wrote:
> On Sun, 3 May 2026 at 05:17, João Fernandes <joaovictor.fernandes@usp.br> wrote:
> >
> > Refactor accel and gyro configuration paths to remove duplicated
> > logic and improve code structure.
> > Introduce a generic helper, inv_icm42600_set_sensor_conf(), to handle
> > common register programming and state updates.
> >
> > Keep sensor-specific handling in inv_icm42600_set_accel_conf() and
> > inv_icm42600_set_gyro_conf() wrappers. Also extract configuration
> > sanitization into a dedicated helper inv_icm42600_sanitize_conf()
> > to further reduce repetition.
>
> This should be (at least) a four-part patch series, please don't send multiple
> logical changes as one patch. Patches should be atomic and only deal with
> one change/fix. Try to introduce preparatory patches when sending, it speeds
> up the reviewing process.
Can you be more specific? It will help the author to split it correctly in less
amount of attempts.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-04 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-03 3:12 [PATCH] iio: imu: inv_icm42600: refactor accel/gyro configuration paths João Fernandes
2026-05-03 9:13 ` Joshua Crofts
2026-05-04 14:17 ` Andy Shevchenko [this message]
2026-05-04 16:17 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afiqYP8PrVpGs0Bq@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gcotavio@usp.br \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=jic23@kernel.org \
--cc=joaovictor.fernandes@usp.br \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox