From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Salah Triki <salah.triki@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: humidity: ens210: Fix missing I2C functionality checks
Date: Tue, 5 May 2026 12:07:04 +0300 [thread overview]
Message-ID: <afmzOM3s_TCYxXyt@ashevche-desk.local> (raw)
In-Reply-To: <20260505090247.74555-1-salah.triki@gmail.com>
On Tue, May 05, 2026 at 10:02:47AM +0100, Salah Triki wrote:
> The ENS210 driver uses both `i2c_smbus_read_byte_data()` and
> `i2c_smbus_read_word_data()` during the read and probe phases.
> However, `i2c_check_functionality()` was only checking for block reads
> and simple byte writes, which could lead to hardware interface
> incompatibilities or errors on certain adapters that do not natively
> support SMBus word or byte data transactions.
>
> Add `I2C_FUNC_SMBUS_READ_BYTE_DATA` and `I2C_FUNC_SMBUS_READ_WORD_DATA`
> to the functionality check mask to ensure the adapter supports the
> required operations before communication begins.
Can we rather modify the driver to use SW emulation for these cases?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-05 9:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 9:02 [PATCH] iio: humidity: ens210: Fix missing I2C functionality checks Salah Triki
2026-05-05 9:07 ` Andy Shevchenko [this message]
2026-05-05 9:28 ` Salah Triki
2026-05-05 9:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afmzOM3s_TCYxXyt@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=salah.triki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox