From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Stepan Ionichev <sozdayvek@gmail.com>
Cc: jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com,
puranjay@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: accel: adxl355: replace usleep_range() with fsleep()
Date: Sun, 10 May 2026 15:54:55 +0300 [thread overview]
Message-ID: <agCAH5ShX3enzwwh@ashevche-desk.local> (raw)
In-Reply-To: <20260510050820.27748-1-sozdayvek@gmail.com>
On Sun, May 10, 2026 at 10:08:20AM +0500, Stepan Ionichev wrote:
> The "at least 5ms" wait after software reset has no specific upper
> bound. Switch to fsleep() which is the kernel helper for plain
> "about N microseconds" delays.
>
> No functional change.
...
> /* Wait at least 5ms after software reset */
> - usleep_range(5000, 10000);
> + fsleep(5000);
Even better to use predefined multiplier:
fsleep(5 * USEC_PER_MSEC);
This gives a hint on the value units without even needing / reading
the comment.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-05-10 12:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 5:08 [PATCH] iio: accel: adxl355: replace usleep_range() with fsleep() Stepan Ionichev
2026-05-10 5:53 ` [PATCH v2] " Stepan Ionichev
2026-05-10 18:09 ` Andy Shevchenko
2026-05-10 12:54 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agCAH5ShX3enzwwh@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=puranjay@kernel.org \
--cc=sozdayvek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox