From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Ethan Tidmore <ethantidmore06@gmail.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad7766: Update to use iio_push_to_buffers_with_ts()
Date: Mon, 11 May 2026 13:40:26 +0300 [thread overview]
Message-ID: <agGyGgI6vlINm-V8@ashevche-desk.local> (raw)
In-Reply-To: <20260510221404.22834-1-ethantidmore06@gmail.com>
On Sun, May 10, 2026 at 05:14:04PM -0500, Ethan Tidmore wrote:
> The old ABI function iio_push_to_buffers_with_timestamp() is no longer
> preferred due to it being inherently unsafe.
>
> Update to the current standard iio_push_to_buffers_with_ts().
Nice, but there is nothing about correctness of the change. This is quite
sensitive area which is ABI. Any breakage is a big deal. Have you studied
the case deeper? What are the contents of the buffers with the old one and
new one versus channels enabled? Is timestamp located in the same offset
in both cases?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-11 10:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 22:14 [PATCH] iio: adc: ad7766: Update to use iio_push_to_buffers_with_ts() Ethan Tidmore
2026-05-11 10:40 ` Andy Shevchenko [this message]
2026-05-11 13:43 ` Jonathan Cameron
2026-05-11 16:05 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agGyGgI6vlINm-V8@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=ethantidmore06@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox