From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Stepan Ionichev <sozdayvek@gmail.com>
Cc: jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com,
antoniu.miclaus@analog.com, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: frequency: adrf6780: replace usleep_range() with fsleep()
Date: Mon, 11 May 2026 16:23:26 +0300 [thread overview]
Message-ID: <agHYTpgmec5nDosZ@ashevche-desk.local> (raw)
In-Reply-To: <20260511054441.2980-1-sozdayvek@gmail.com>
On Mon, May 11, 2026 at 10:44:41AM +0500, Stepan Ionichev wrote:
> The ADRF6780 datasheet (Rev. D, page 23, ADC section) says:
> "Wait approximately 200 us for the ADC to be ready."
>
> fsleep(200) expands to the same usleep_range(200, 250). Use the
> flexible sleep helper, which picks the right primitive for the
> given microsecond delay.
>
> Replace the generic "Recommended delay for the ADC to be ready"
> comment with the datasheet reference so the "why" of the wait is
> visible at the call site.
>
> No functional change.
In this case the commit message is fine.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-05-11 13:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 5:44 [PATCH] iio: frequency: adrf6780: replace usleep_range() with fsleep() Stepan Ionichev
2026-05-11 13:18 ` Joshua Crofts
2026-05-11 13:23 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agHYTpgmec5nDosZ@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sozdayvek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox