From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Stepan Ionichev <sozdayvek@gmail.com>
Cc: jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com,
alisa.roman@analog.com, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] iio: adc: ad7192: replace usleep_range() with fsleep()
Date: Mon, 11 May 2026 16:28:39 +0300 [thread overview]
Message-ID: <agHZh32XjOMcPv2F@ashevche-desk.local> (raw)
In-Reply-To: <20260511025545.41631-1-sozdayvek@gmail.com>
On Mon, May 11, 2026 at 07:55:44AM +0500, Stepan Ionichev wrote:
> The AD7192 datasheet (Rev. A, page 34, RESET section) says:
> "When a reset is initiated, the user must allow a period of
> 500 us before accessing any of the on-chip registers."
> Use fsleep(500) instead of usleep_range(500, 1000). The 500 us
> minimum stays the same; fsleep() picks the upper slack itself
> (about +25% on a default config).
The second sentence here...
> Add a code comment with the datasheet reference so the "why"
> of the wait is visible at the call site.
...and this paragraph are unneeded details.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-11 13:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 11:39 [PATCH v3] iio: adc: ad7192: replace usleep_range() with fsleep() Stepan Ionichev
2026-05-11 2:55 ` [PATCH v4] " Stepan Ionichev
2026-05-11 13:28 ` Andy Shevchenko [this message]
2026-05-11 16:10 ` Jonathan Cameron
2026-05-11 7:29 ` [PATCH v3] " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agHZh32XjOMcPv2F@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=alisa.roman@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sozdayvek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox