From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Stepan Ionichev <sozdayvek@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, gregkh@linuxfoundation.org, hcazarim@yahoo.com,
joshua.crofts1@gmail.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: trigger: iio-trig-interrupt: use devm_* helpers
Date: Mon, 11 May 2026 18:05:36 +0300 [thread overview]
Message-ID: <agHwQAn3iq7L7eF8@ashevche-desk.local> (raw)
In-Reply-To: <20260511063229.1433-1-sozdayvek@gmail.com>
On Mon, May 11, 2026 at 11:32:29AM +0500, Stepan Ionichev wrote:
> Convert to devm_iio_trigger_alloc(), devm_request_irq() and
> devm_iio_trigger_register(). The driver-managed lifecycle removes
> the manual error-cleanup ladder in probe and the entire .remove()
> callback.
>
> Drop the now-unused iio_interrupt_trigger_info structure: its
> only purpose was to hold the IRQ number for the manual free_irq()
> call in .remove(), which is no longer needed. The matching
> linux/slab.h include is also dropped.
...
> Signed-off-by: Stepan Ionichev <sozdayvek@gmail.com>
> ---
> v2:
> - Drop the dev_err() call after devm_request_irq(); really_probe()
> in the driver core already logs probe failures, so the message
> would be duplicate (per Andy)
FWIW, it's IRQ core (not driver core!) that does printing.
> - Use a local struct device *dev = &pdev->dev (per Joshua)
> - Drop the "No functional change" claim from the commit message;
> the resource lifecycle model changes (per Joshua)
> - Use .remove() function notation in the commit message (per Andy)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-11 15:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 6:07 [PATCH] iio: trigger: iio-trig-interrupt: use devm_* helpers Stepan Ionichev
2026-05-11 6:32 ` [PATCH v2] " Stepan Ionichev
2026-05-11 13:53 ` Joshua Crofts
2026-05-11 14:56 ` Jonathan Cameron
2026-05-11 15:05 ` Andy Shevchenko [this message]
2026-05-11 6:36 ` [PATCH] " Stepan Ionichev
2026-05-11 6:44 ` Stepan Ionichev
2026-05-11 13:33 ` Joshua Crofts
2026-05-11 6:27 ` Stepan Ionichev
2026-05-11 13:48 ` Joshua Crofts
2026-05-11 13:46 ` Andy Shevchenko
2026-05-11 13:38 ` Andy Shevchenko
2026-05-13 8:33 ` Stepan Ionichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agHwQAn3iq7L7eF8@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=hcazarim@yahoo.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sozdayvek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox