Linux IIO development
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
	andy@kernel.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: mapping file for include-what-you-use tool
Date: Tue, 12 May 2026 11:00:18 +0300	[thread overview]
Message-ID: <agLeEitdYsi5O2E1@ashevche-desk.local> (raw)
In-Reply-To: <20260512073505.1310-1-joshua.crofts1@gmail.com>

On Tue, May 12, 2026 at 07:35:05AM +0000, Joshua Crofts wrote:
> As promised, I'm sending my IWYU mapping file, based on Jonathan's
> version with a few additional tweaks by me.

Please, also add a link to Jonathan's version.

> Other than adding support for more assembly file business, I've also
> experimented with individual symbol definition (see BIT() and GENMASK()
> in the following file) - this is to prevent issues such as the tool
> wanting you to include <linux/bits.h> when you already have
> <linux/bitops.h> in the source file (I agree, doing this symbol by
> symbol is tedious, but BIT() and GENMASK() are symbols that especially
> do this, and they're included in most, if not all drivers).
> 
> Feel free to improve this file and pass it on. I wouldn't really fully
> rely on IWYU as even with the mapping file the results can be weird,
> but it definitely serves as a good starting point when doing driver
> cleanup.
> 
> I'm making this patch an RFC - this is not intended for merging.

...


> +    { "include": ["\"vdso/bits.h\"", "private", "<linux/bits.h>", "public"] },
> +    { "include": ["\"vdso/ktime.h\"", "private", "<linux/ktime.h>", "public"] },
> +    { "include": ["\"vdso/limits.h\"", "private", "<linux/limits.h>", "public"] },
> +    { "include": ["\"vdso/time64.h\"", "private", "<linux/time64.h>", "public"] },

> +    

Trailing whitespaces.

> +    { "include": ["\"asm-generic/div64.h\"", "private", "<linux/math64.h>", "public"] },
> +    { "include": ["\"asm-generic/errno.h\"", "private", "<linux/errno.h>", "public"] },
> +    { "include": ["\"asm-generic/errno-base.h\"", "private", "<linux/errno.h>", "public"] },
> +    { "include": ["\"asm-generic/int-ll64.h\"", "private", "<linux/types.h>", "public"] },

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2026-05-12  8:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12  7:35 [PATCH] iio: mapping file for include-what-you-use tool Joshua Crofts
2026-05-12  7:36 ` Joshua Crofts
2026-05-12  8:00   ` Andy Shevchenko
2026-05-12  8:00 ` Andy Shevchenko [this message]
2026-05-12  8:04   ` Joshua Crofts
2026-05-12  8:07     ` Andy Shevchenko
2026-05-12  8:10       ` Joshua Crofts
2026-05-12 15:36 ` David Lechner
2026-05-12 15:51   ` Andy Shevchenko
2026-05-12 15:57     ` David Lechner
2026-05-13  8:24       ` Joshua Crofts
2026-05-12 17:07   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agLeEitdYsi5O2E1@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=joshua.crofts1@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox