From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Maxwell Doose <m32285159@gmail.com>
Cc: jic23@kernel.org, sashiko <sashiko-bot@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Daniel Baluta" <daniel.baluta@intel.com>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] iio: imu: kmx61: Fix potential time-of-check to time-of-use race
Date: Wed, 13 May 2026 14:25:24 +0300 [thread overview]
Message-ID: <agRfpI_eqG7QHYas@ashevche-desk.local> (raw)
In-Reply-To: <20260513013638.147606-1-m32285159@gmail.com>
On Tue, May 12, 2026 at 08:36:38PM -0500, Maxwell Doose wrote:
The Subject can be made better:
iio: imu: kmx61: Fix potential TOCTOU race in kmx61_write_event_config()
> A time-of-check to time-of-use race condition exists in
> kmx61_write_event_config(). If two threads enter the function at the
> same time, both threads may pass the check and get to the lock. Thus,
> when the first thread releases the lock allowing the second thread to
> start execution after the first thread modifies data->ev_enable_state to
> force returning from the function, the second thread continues execution
> regardless. Fix this by moving the data->ev_enable_state check inside of
> the critical section.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-13 11:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 1:36 [PATCH v2] iio: imu: kmx61: Fix potential time-of-check to time-of-use race Maxwell Doose
2026-05-13 1:39 ` Maxwell Doose
2026-05-13 7:35 ` Joshua Crofts
2026-05-13 11:25 ` Andy Shevchenko [this message]
2026-05-13 15:00 ` Maxwell Doose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agRfpI_eqG7QHYas@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=daniel.baluta@intel.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m32285159@gmail.com \
--cc=nuno.sa@analog.com \
--cc=sashiko-bot@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox