From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Дамјан Гео ргиевски" <gdamjan@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: buffer: only set IRQF_ONESHOT when thread handler is provided
Date: Fri, 15 May 2026 13:46:30 +0300 [thread overview]
Message-ID: <agb5hiF6GhNwGa6c@ashevche-desk.local> (raw)
In-Reply-To: <20260515-patch-iio-buffer-v1-1-667dac4e55e5@gmail.com>
On Fri, May 15, 2026 at 12:46:00AM +0200, Дамјан Гео ргиевски wrote:
> iio_triggered_buffer_setup_ext() unconditionally passes IRQF_ONESHOT to
> iio_alloc_pollfunc(), even when the caller provides no thread function.
> This causes a warning in __setup_irq() when the trigger is later
> attached:
>
> WARNING: kernel/irq/manage.c:1502 at __setup_irq+0x4ee/0x700
>
> IRQF_ONESHOT keeps the IRQ masked until the threaded handler completes,
> but with no threaded handler this is semantically wrong. Only set the
> flag when a thread function is actually provided.
Yes, please read the mailing list archive and find the previous attempt to fix
this and the associated discussions.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-15 10:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 22:46 [PATCH] iio: buffer: only set IRQF_ONESHOT when thread handler is provided Дамјан Гео ргиевски
2026-05-15 10:46 ` Andy Shevchenko [this message]
2026-05-15 14:20 ` Jonathan Cameron
2026-05-15 14:47 ` Damjan Georgievski
2026-05-15 14:55 ` Jonathan Cameron
2026-05-15 15:09 ` Damjan Georgievski
2026-05-15 19:22 ` Damjan Georgievski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agb5hiF6GhNwGa6c@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gdamjan@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox