From: Dan Carpenter <error27@gmail.com>
To: Jad Keskes <inasj268@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-iio@vger.kernel.org,
Jonathan Cameron <jic23@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] staging: iio: addac: drop CamelCase from adt7316 symbol names
Date: Tue, 2 Jun 2026 16:38:57 +0300 [thread overview]
Message-ID: <ah7c8XZHmvWu5eI7@stanley.mountain> (raw)
In-Reply-To: <20260602132534.101554-1-inasj268@gmail.com>
The V in Vref stands for "Voltage". It is supposed to be capitalized.
In this case correctness is more important than checkpatch. The others
aren't checkpatch warnings or style issues so they're fine as-is as
well.
Also you renamed some "DA" things to "dac" and it's not clear why and
it's not explained in the commit message. Try to be more careful
about that going forward.
regards,
dan carpenter
prev parent reply other threads:[~2026-06-02 13:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 13:25 [PATCH] staging: iio: addac: drop CamelCase from adt7316 symbol names Jad Keskes
2026-06-02 13:38 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah7c8XZHmvWu5eI7@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=inasj268@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox