From: Dan Carpenter <error27@gmail.com>
To: Nuno Sa <nuno.sa@analog.com>
Cc: Olivier Moysan <olivier.moysan@foss.st.com>,
Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH] iio: backend: fix uninitialized data in debugfs
Date: Mon, 25 May 2026 10:16:11 +0300 [thread overview]
Message-ID: <ahP3O2tQdu4dNx_c@stanley.mountain> (raw)
If the *ppos value is non-zero then simple_write_to_buffer() will not
initialize the start of the buf[] buffer. Non-zero ppos values aren't
going to work at all. Check for that at the start of the function and
return -EINVAL.
Fixes: cdf01e0809a4 ("iio: backend: add debugFs interface")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
drivers/iio/industrialio-backend.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/industrialio-backend.c b/drivers/iio/industrialio-backend.c
index 138ebebc9c0d..4763e224ebc6 100644
--- a/drivers/iio/industrialio-backend.c
+++ b/drivers/iio/industrialio-backend.c
@@ -156,7 +156,7 @@ static ssize_t iio_backend_debugfs_write_reg(struct file *file,
ssize_t rc;
int ret;
- if (count >= sizeof(buf))
+ if (*ppos != 0 || count >= sizeof(buf))
return -ENOSPC;
rc = simple_write_to_buffer(buf, sizeof(buf) - 1, ppos, userbuf, count);
--
2.53.0
next reply other threads:[~2026-05-25 7:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 7:16 Dan Carpenter [this message]
2026-05-25 13:20 ` [PATCH] iio: backend: fix uninitialized data in debugfs Maxwell Doose
2026-05-26 18:19 ` Jonathan Cameron
2026-06-04 7:30 ` Andy Shevchenko
2026-06-04 7:38 ` Andy Shevchenko
2026-06-04 7:45 ` Dan Carpenter
2026-06-04 8:03 ` Andy Shevchenko
2026-06-04 8:28 ` Andy Shevchenko
2026-06-04 10:38 ` Dan Carpenter
2026-06-04 10:42 ` Dan Carpenter
2026-06-04 14:55 ` Andy Shevchenko
2026-06-05 6:12 ` Dan Carpenter
2026-06-05 8:28 ` Andy Shevchenko
2026-06-05 14:38 ` Maxwell Doose
2026-06-08 20:31 ` Nuno Sá
2026-06-08 21:51 ` Maxwell Doose
2026-06-09 8:10 ` Nuno Sá
2026-06-04 14:52 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahP3O2tQdu4dNx_c@stanley.mountain \
--to=error27@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox