From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Hungyu Lin <dennylin0707@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] iio: magnetometer: bmc150: use FIELD_PREP and FIELD_GET helpers
Date: Tue, 9 Jun 2026 18:25:28 +0300 [thread overview]
Message-ID: <aigwaLHACg_nQUvl@ashevche-desk.local> (raw)
In-Reply-To: <CAGEkeHf9c5dOMJbryGF7VW-TaJRXOrkLRs5oeRH21fv5ybCGcg@mail.gmail.com>
On Tue, Jun 09, 2026 at 08:12:30AM -0700, Hungyu Lin wrote:
> > You need to slow down. The comment I gave from the previous round still
> > applies. Now even more, id est the location of new header is chosen in
> > suboptimal way. Always try to keep as much as possible headers sorted.
>
> Thanks for the review.
>
> I'll remove the blank line.
>
> Could you suggest the preferred placement
> for <linux/bitfield.h> in this include list?
As I said, create an additional (prerequisite) patch that sorts them first.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-06-09 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 2:01 [PATCH v3] iio: magnetometer: bmc150: use FIELD_PREP and FIELD_GET helpers Hungyu Lin
2026-06-09 14:44 ` Andy Shevchenko
2026-06-09 15:12 ` Hungyu Lin
2026-06-09 15:25 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aigwaLHACg_nQUvl@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dennylin0707@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox