Re: [PATCH v2 0/3] iio: light: al3xxx: add missing REGMAP_I2C to Kconfig entries

["Nuno Sá" <noname.nuno@gmail.com>]

On Fri, Jun 26, 2026 at 03:26:06PM +0300, Andy Shevchenko wrote:
> On Thu, Jun 25, 2026 at 09:38:07PM +0200, Joshua Crofts wrote:
> > This series adds REGMAP_I2C support to three AL3xxx ambient light
> > sensors that were previously missing this dependency, causing build
> > failures.
> > 
> > To reproduce the build failure, run `make allnoconfig` and `make menuconfig`
> > in which you select IIO, I2C and any AL3xxx sensor and `make .` will
> > fail with errors such as:
> > 
> > drivers/iio/light/al3010.c: In function ‘al3010_probe’:
> > drivers/iio/light/al3010.c:185:24: error: implicit declaration of function ‘devm_regmap_init_i2c’ [-Wimplicit-function-declaration]
> >   185 |         data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config);
> >       |                        ^~~~~~~~~~~~~~~~~~~~
> > drivers/iio/light/al3010.c:185:22: error: assignment to ‘struct regmap *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
> >   185 |         data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config);
> >       |                      ^
> > drivers/iio/light/al3010.c: At top level:
> > drivers/iio/light/al3010.c:48:35: error: storage size of ‘al3010_regmap_config’ isn’t known
> >    48 | static const struct regmap_config al3010_regmap_config = {
> >       |                                   ^~~~~~~~~~~~~~~~~~~~
> 
> Now all is better. The only thing is missing is Cc: stable@ line.

I'm not sure we have a defined policy for that in IIO. Now that you
mention it, maybe time to ask...

My understanding always was that Jonathan takes care of Ccing stable
but maybe he just does it and being nice about it, does not complain :).

So, Jonathan,

Should the sender take care about Cc or not? Or it does not really matter
:)?

- Nuno Sá

> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> 
> > I made a separate commit for each driver, to ensure a proper Fixes:
> > tag is appended for easy backporting. Let me know if you prefer
> > squashing!
> 
> I prefer per-driver patches, but let Jonathan to handle that.
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>