From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Caio Groff <caio.groff@usp.br>
Cc: nuno.sa@analog.com, Michael.Hennerich@analog.com,
marcelo.schmitt@analog.com, antoniu.miclaus@analog.com,
jic23@kernel.org, dlechner@baylibre.com, andy@kernel.org,
linux@analog.com, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: accel: adxl372: replace manual bitfield ops with FIELD_GET()
Date: Wed, 8 Jul 2026 09:26:34 +0300 [thread overview]
Message-ID: <ak3tmgh9nUn6MkHs@ashevche-desk.local> (raw)
In-Reply-To: <20260708013002.1377142-1-caio.groff@usp.br>
On Tue, Jul 07, 2026 at 10:29:27PM -0300, Caio Groff wrote:
> Replace manual bit shifting and masking with FIELD_GET()
> macros for clarity and consistency with kernel coding style.
...
> +/* ADXL372_TIME_INACT */
> +#define ADXL372_TIME_INACT_MASK_H GENMASK(15, 8)
> +#define ADXL372_TIME_INACT_MASK_L GENMASK(7, 0)
> +
> +
A single blank line is enough.
...
> res = DIV_ROUND_CLOSEST(inact_time_ms, scale_factor);
> - reg_val_h = (res >> 8) & 0xFF;
> - reg_val_l = res & 0xFF;
> -
> + reg_val_h = FIELD_GET(ADXL372_TIME_INACT_MASK_H, res);
> + reg_val_l = FIELD_GET(ADXL372_TIME_INACT_MASK_L, res);
> ret = regmap_write(st->regmap, ADXL372_TIME_INACT_H, reg_val_h);
> if (ret < 0)
> return ret;
The whole driver uses bulk reads and writes, why this can't be modified to
perform regmap_bulk_write() with the __be16 type?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-07-08 6:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 1:29 [PATCH] iio: accel: adxl372: replace manual bitfield ops with FIELD_GET() Caio Groff
2026-07-08 2:50 ` Maxwell Doose
2026-07-08 6:26 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak3tmgh9nUn6MkHs@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=caio.groff@usp.br \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux@analog.com \
--cc=marcelo.schmitt@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox