From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: light: vcnl4035: Propagate regcache_sync() errors
Date: Sat, 4 Jul 2026 15:11:14 +0300 [thread overview]
Message-ID: <akj4Yr086hmW7AJg@ashevche-desk.local> (raw)
In-Reply-To: <20260704071410.18757-1-pengpeng@iscas.ac.cn>
On Sat, Jul 04, 2026 at 03:14:10PM +0800, Pengpeng Hou wrote:
> vcnl4035_runtime_suspend() marks the regmap cache dirty before runtime
> suspend. vcnl4035_runtime_resume() then syncs the cache before re-
> enabling ALS, but currently ignores a regcache_sync() failure and can
> still report resume success.
>
> Return the regcache_sync() error so the PM core sees the failed register
> restore.
...
> - regcache_sync(data->regmap);
> + ret = regcache_sync(data->regmap);
> + if (ret < 0)
> + return ret;
When do like this, add a blank line.
Same comment to all similar patches you sent (or about to send).
> ret = vcnl4035_set_als_power_state(data, VCNL4035_MODE_ALS_ENABLE);
> if (ret < 0)
> return ret;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-07-04 12:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-04 7:14 [PATCH] iio: light: vcnl4035: Propagate regcache_sync() errors Pengpeng Hou
2026-07-04 12:11 ` Andy Shevchenko [this message]
2026-07-11 22:37 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akj4Yr086hmW7AJg@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=pengpeng@iscas.ac.cn \
--cc=sakari.ailus@linux.intel.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox