From: Lukas <lukas.metz@gmx.net>
To: Conor Dooley <conor@kernel.org>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: dac: Add DAC8163
Date: Tue, 14 Jul 2026 17:01:58 +0200 [thread overview]
Message-ID: <alZPZuAQfiROz8kf@berta-MS-7693> (raw)
In-Reply-To: <20260708-spotty-spectacle-f270b4c66d18@spud>
On Wed, Jul 08, 2026 at 05:37:44PM +0100, Conor Dooley wrote:
> > + clr-gpios:
> > + description:
> > + The device registers are reset when this pin is asserted. The output is
> > + set to zero (xxx2 devices) or mid-scale (xxx3 devices).
> > + maxItems: 1
> > +
>
> Sounds like this should be reset-gpios?
>
Thanks for pointing this out. The description is actually wrong. The
datasheet says: "On activation of CLR, zero scale (DACxx62) or
mid-scale (DACxx63) is loaded to all input and DAC registers".
That means other registers are unaffected. I will update the description
but the clr-gpios is correct in this case i guess?
Best regards
Lukas
next prev parent reply other threads:[~2026-07-14 15:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 9:52 [PATCH v2 0/2] Add driver for DAC8163: Lukas Metz
2026-07-08 9:52 ` [PATCH v2 1/2] dt-bindings: iio: dac: Add DAC8163 Lukas Metz
2026-07-08 16:37 ` Conor Dooley
2026-07-14 15:01 ` Lukas [this message]
2026-07-14 16:49 ` Conor Dooley
2026-07-14 19:25 ` David Lechner
2026-07-08 9:52 ` [PATCH v2 2/2] iio: dac: dac8163: Add driver for DAC8163 Lukas Metz
2026-07-08 11:32 ` Andy Shevchenko
2026-07-09 10:03 ` Lukas
2026-07-09 10:19 ` Andy Shevchenko
2026-07-08 15:58 ` Siratul Islam
2026-07-08 17:33 ` Jonathan Cameron
2026-07-08 19:04 ` Siratul Islam
2026-07-12 22:23 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alZPZuAQfiROz8kf@berta-MS-7693 \
--to=lukas.metz@gmx.net \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox