Re: [PATCH][next] iio: adc: make read-only const array config static

[Dan Carpenter <error27@gmail.com>]

On Tue, Jul 14, 2026 at 08:08:10PM +0300, Andy Shevchenko wrote:
> On Tue, Jul 14, 2026 at 05:50:12PM +0100, Colin Ian King wrote:
> > Don't populate the read-only const array config on the stack at run
> > time, instead make it static.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> 
> ...
> 
> In all patches like this it's always a bikeshedding possible of moving static
> data outside of a function. I have no strong opinion in these cases (when the
> data solely used by a single function), but in general it might give different
> readability experience (it's harder to notice static data in the local function
> definition block). So I leave this exercise to the maintainers of the respective
> pieces of the code.
> 

It's an interesting point...

At one point Smatch didn't track static variables and it used to
generate occasional false positives.  And it's like you say, those
little "static" qualifiers are hard to spot in a wall of declaration
text.  I've never considered moving the declarations out of the
function scope but it might be a good idea?

But in this case since this data is const, the static vs not-static
doesn't affect flow analysis or readability.

regards,
dan carpenter