From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: OrangeBlack0765@outlook.com
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] iio: light: tsl2583: migrate to sysfs_emit() and sysfs_emit_at()
Date: Thu, 16 Jul 2026 23:12:15 +0300 [thread overview]
Message-ID: <alk7H41lph_OxMfb@ashevche-desk.local> (raw)
In-Reply-To: <OS3PR01MB824492E7AFD347208E0C149AAFC72@OS3PR01MB8244.jpnprd01.prod.outlook.com>
On Thu, Jul 16, 2026 at 09:04:35AM +0800, OrangeBlack0765@outlook.com wrote:
> Replace sprintf() with sysfs_emit() for single-value sysfs show
> functions, and use sysfs_emit_at() for lux_table_show() which
> concatenates multiple values. This ensures buffer safety and
> follows the modern kernel sysfs API.
Now it looks good to me.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-07-16 20:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 1:04 [PATCH v3] iio: light: tsl2583: migrate to sysfs_emit() and sysfs_emit_at() OrangeBlack0765
2026-07-16 20:12 ` Andy Shevchenko [this message]
2026-07-20 1:51 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alk7H41lph_OxMfb@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=OrangeBlack0765@outlook.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox