From: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: iio/accel/stk8312: Improve unlocking of a mutex in two functions
Date: Fri, 27 Oct 2017 13:15:58 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1710271254570.17368@vps.pmeerw.net> (raw)
In-Reply-To: <c2620449-b80a-f0ef-c0d2-92d0c7fb4906@users.sourceforge.net>
[-- Attachment #1: Type: text/plain, Size: 848 bytes --]
Hello,
> Maybe …
> But I proposed an other source code layout for useful reasons.
I think there is a (hidden) cost of having pure cleanup patches:
they make backporting fixes harder (across the cleanup)
stylistic changes must have a clear benefit, readability is subjective,
consistency per se doesn't buy anything
the discussion how code should be written in the first place is separate
from the discussion what is worth fixing up lateron (IMHO)
> > There is no firm rule about error handling in one place.
>
> There are some design options available.
>
>
> > If it leads to more complex flow as here, don't do it.
>
> I would appreciate to clarify such a view a bit more.
> How would you like to achieve a complete and efficient
> exception handling in shown places?
regards, p.
--
Peter Meerwald-Stadler
Mobile: +43 664 24 44 418
next prev parent reply other threads:[~2017-10-27 11:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 18:55 [PATCH] iio/accel/stk8312: Improve unlocking of a mutex in two functions SF Markus Elfring
2017-10-26 16:09 ` Jonathan Cameron
2017-10-27 10:15 ` SF Markus Elfring
2017-10-27 11:15 ` Peter Meerwald-Stadler [this message]
2017-10-27 12:37 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1710271254570.17368@vps.pmeerw.net \
--to=pmeerw@pmeerw.net \
--cc=elfring@users.sourceforge.net \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).