From: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Javier Martinez Canillas <javierm@redhat.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Xiongfeng Wang <xiongfeng.wang@linaro.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] IIO: st_accel_i2c.c: Use probe_new() instead of probe()
Date: Wed, 4 Jul 2018 15:24:03 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1807041501420.11004@fox.voss.local> (raw)
In-Reply-To: <CABxcv==xgZb5iyupLvFno=JNnxWnkyD8stFjACz_x756Lm2yRA@mail.gmail.com>
On Wed, 4 Jul 2018, Javier Martinez Canillas wrote:
> On Wed, Jul 4, 2018 at 2:31 PM, Nikolaus Voss
> <nikolaus.voss@loewensteinmedical.de> wrote:
>> On Wed, 4 Jul 2018, Javier Martinez Canillas wrote:
>>>
>>> On Wed, Jul 4, 2018 at 1:46 PM, Nikolaus Voss
>>> <nikolaus.voss@loewensteinmedical.de> wrote:
>>>
>>
>> [snip]
>>
>>> But this discussion isn't really related to your patch. I think is
>>> correct but just said that (b) wasn't a justification to leave the I2C
>>> table, points (a) and (c) are though. I won't really be convinced that
>>> the fallback is the correct thing to do or even a good idea.
>>
>>
>> I didn't want to annoy you, I just wanted to understand why you think
>> fallback is such a bad thing that you call it a bug. And I see, it has its
>> drawbacks ;-). Anyway, thanks for taking the time to clarify this,
>>
>
> Oh, I'm not annoyed, sorry if I sounded that way. What I tried to say
> is that I've a strong opinion on this and won't be convinced otherwise
> :)
>
> So for me is a bug because that would mean that either an entry is
> missing in an OF device table or a DTS has a node with a compatible
> string without a vendor prefix.
Yes, I see your point (and your strong opinion :-)), but AFAIK vendor
prefix is not mandatory... At least for vendor-agnostic drivers like
"regulator-fixed" (very popular in dts files). My point is not bloating
drivers with large redundant (from a driver-functional view) tables when
one table could be enough for a properly working driver. Having three
different names for exactly the same isn't very beautiful IMO.
I hope you're still not annoyed...
Niko
next prev parent reply other threads:[~2018-07-04 13:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 6:34 [PATCH v2 0/2] IIO: st_sensors_i2c: improve device enumeration Nikolaus Voss
2018-07-03 5:41 ` [PATCH v2 1/2] IIO: st_accel_i2c.c: Simplify access to driver data Nikolaus Voss
2018-07-03 21:07 ` Andy Shevchenko
2018-07-04 6:56 ` Nikolaus Voss
2018-07-04 9:00 ` Andy Shevchenko
2018-07-03 6:06 ` [PATCH v2 2/2] IIO: st_accel_i2c.c: Use probe_new() instead of probe() Nikolaus Voss
2018-07-03 22:54 ` Andy Shevchenko
2018-07-04 6:37 ` Nikolaus Voss
2018-07-04 8:58 ` Andy Shevchenko
2018-07-04 9:09 ` Nikolaus Voss
2018-07-04 9:16 ` Andy Shevchenko
2018-07-04 9:42 ` Nikolaus Voss
2018-07-04 10:19 ` Andy Shevchenko
2018-07-04 10:49 ` Javier Martinez Canillas
2018-07-04 11:15 ` Nikolaus Voss
2018-07-04 11:26 ` Javier Martinez Canillas
2018-07-04 11:32 ` Javier Martinez Canillas
2018-07-04 11:46 ` Nikolaus Voss
2018-07-04 12:09 ` Javier Martinez Canillas
2018-07-04 12:31 ` Nikolaus Voss
2018-07-04 12:37 ` Javier Martinez Canillas
2018-07-04 13:24 ` Nikolaus Voss [this message]
2018-07-04 13:44 ` Javier Martinez Canillas
2018-07-04 16:11 ` Andy Shevchenko
2018-07-04 18:53 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1807041501420.11004@fox.voss.local \
--to=nikolaus.voss@loewensteinmedical.de \
--cc=andy.shevchenko@gmail.com \
--cc=javier@dowhile0.org \
--cc=javierm@redhat.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=xiongfeng.wang@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox