From: Julia Lawall <julia.lawall@inria.fr>
To: Enrique Vargas <jevargas@seas.upenn.edu>
Cc: Chas Williams <3chas3@gmail.com>,
linux-iio@vger.kernel.org, Greg KH <gregkh@linuxfoundation.org>,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] remove unnecessary newline for brace
Date: Wed, 11 Mar 2020 13:56:54 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.2003111355390.2999@hadrien> (raw)
In-Reply-To: <20200311125507.GA9347@evX1>
The subject line should give information about what part of the kernel is
being changed. See other patches or the tutorial for examples.
On Wed, 11 Mar 2020, Enrique Vargas wrote:
> put brace at the end of line following coding conventions
>
> Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
> ---
> drivers/atm/adummy.c | 3 +--
Is there a reason why you are working on drivers/atm? Normally for the
application period you should only do cleanups on drivers/staging.
julia
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/atm/adummy.c b/drivers/atm/adummy.c
> index 8157925af824..6eeaa1b21f3b 100644
> --- a/drivers/atm/adummy.c
> +++ b/drivers/atm/adummy.c
> @@ -131,8 +131,7 @@ adummy_proc_read(struct atm_dev *dev, loff_t *pos, char *page)
> return 0;
> }
>
> -static const struct atmdev_ops adummy_ops =
> -{
> +static const struct atmdev_ops adummy_ops = {
> .open = adummy_open,
> .close = adummy_close,
> .send = adummy_send,
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200311125507.GA9347%40evX1.
>
next prev parent reply other threads:[~2020-03-11 12:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 12:55 [PATCH] remove unnecessary newline for brace Enrique Vargas
2020-03-11 12:56 ` Julia Lawall [this message]
2020-03-11 13:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2003111355390.2999@hadrien \
--to=julia.lawall@inria.fr \
--cc=3chas3@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jevargas@seas.upenn.edu \
--cc=linux-iio@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox