From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6576C10DCE for ; Thu, 12 Mar 2020 14:38:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A0D672071B for ; Thu, 12 Mar 2020 14:38:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727672AbgCLOie (ORCPT ); Thu, 12 Mar 2020 10:38:34 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:20035 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727359AbgCLOie (ORCPT ); Thu, 12 Mar 2020 10:38:34 -0400 X-IronPort-AV: E=Sophos;i="5.70,545,1574118000"; d="scan'208";a="342154099" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2020 15:38:32 +0100 Date: Thu, 12 Mar 2020 15:38:31 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Enrique Vargas cc: Lars-Peter Clausen , Michael Hennerich , Stefan Popa , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman , linux-iio@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] Staging: iio: adc: align multi-line function argument with open parenthesis In-Reply-To: <20200312142721.GA2748@evX1> Message-ID: References: <20200312142721.GA2748@evX1> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Thu, 12 Mar 2020, Enrique Vargas wrote: > Eliminate WARNING found with checkpatch.pl for argument split in two > lines not matching coding conventions identation. The message seems a bit obscure. There is no argument that is split in two lines, although it is the case that the argument list is split in two lines. For the subject line, maybe "reduce parameter indentation" And then for the log message: "Align function parameter with the right side of the open parenthesis starting the parameter list, to follow kernel coding style. Problem found using checkpatch." julia > > Signed-off-by: Enrique Vargas > --- > drivers/staging/iio/adc/ad7192.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c > index 51b1cd3ad1de..5f65d084e320 100644 > --- a/drivers/staging/iio/adc/ad7192.c > +++ b/drivers/staging/iio/adc/ad7192.c > @@ -477,7 +477,7 @@ static ssize_t ad7192_set(struct device *dev, > } > > static void ad7192_get_available_filter_freq(struct ad7192_state *st, > - int *freq) > + int *freq) > { > unsigned int fadc; > > -- > 2.17.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200312142721.GA2748%40evX1. >