From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f182.google.com (mail-vk1-f182.google.com [209.85.221.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8777243CE70 for ; Fri, 24 Jul 2026 14:39:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784903956; cv=none; b=igZtLIspHJMJWhjV0dFlqhOv98ZViI+cYItfEzPG9MFJ07Klu18qMi5jwA1Dio+339geVXQYHvneXww9D0m7GxKgM8C6BXpighcS+LIPrRF9rUrTSIUN9Yss6PinMtj8rMd8PWwI7vE30kJdtwfX+O9SVzdd7tvLPuiH7eOFPhk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784903956; c=relaxed/simple; bh=qwH94DLIB7dhjexW2Ov73pc9+u+IGg0Yc9qPyosGQS4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZE5+5U3MkW0KNsPhFZDkmWOdkESJh1XCzbKLzoa4qTE6lPdx1Uh1v+Q2q24Wznup0AOTG8rqnG7kmmOloVCWoC9yCo7r1pChYJP5+lbTyNr57jHMl3fcT9wco/voSgS/JWCK0exNmU9rjlkmL28GOeWal3dnoko1P8NdqnZFG5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wg6klG1P; arc=none smtp.client-ip=209.85.221.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wg6klG1P" Received: by mail-vk1-f182.google.com with SMTP id 71dfb90a1353d-5bf9466867cso152300e0c.2 for ; Fri, 24 Jul 2026 07:39:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784903948; x=1785508748; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=T8TvgdhQY1bgvemL1xhDLy9Sz7Qig1A4ISSSjeskkls=; b=Wg6klG1PMBf0BowYfiFXTJ+Gtmf3KIjQTbM/4CqW0HuXAJv5BoiAqd9bHxWWeCvYTR qoipQQjviyRNHUaaU+Us+cPwDNszIr9w87XPbG3HNA9nx3jszBfiA3S03ODqGqLkAh6e oFfj1eUnaZiK2aT3hlcHfPDWn3o8hqQV9LJT8Nb6frSg2ot/A6VYPLzSEUkp/yFrNz+4 Da0lMSAtFh6Q5FqzIUyvGtpyeiO1d5bdHQKr2EkhWZlPJ6hBh68667ormLDN6K6XUm4t fcEYEXYPusbEKwUr0giTcZY4POEUawhH1N+J6hVluj/k01LZf+0Ic3pWY0cCTw7zoBIk Z13g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784903948; x=1785508748; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=T8TvgdhQY1bgvemL1xhDLy9Sz7Qig1A4ISSSjeskkls=; b=lhbAu2F9rZn0bmn9gTLJj1VT0OLYG4EQmo4qOsjJ5Lc5vJr7ju+1qSgXSLShuzcM0L BwAToIuOjyCBTnlDb+cv7fWiGrWoK/rvz9UXSH/w5kZA3bisocnlgzXeTTvuHM3s9+4k U8HBWIBofhlENu0I8cmCrbfNAFLJ3KqIsB75blCFf52sWWDK9E9neY5SUlj6kRwUyPjg vcCJvy3ed3JTVY025ad52j0yYihhp14SXfZ/FwzNKPTBbFINYRwygSgbdh2hBc7KkYZ/ 2gsa+I+dje3vE/SZZ3MSlPgaj7X5Tpfhqxfa7O5n7MbjlDItB2m0aalvGBM4c9U1jSL+ 8CTw== X-Gm-Message-State: AOJu0YybmAPpbMvlbVyl+XxsVtqhVrprwgnO51sDgKsPaCLGxK38w7wi yhDZDBXjsjlkwHBP5RF8KxMbCvusOsMmAxUiSKkooNYTHJiSsrl96bGjVYG00g== X-Gm-Gg: AR+sD118ZLt2YwbCRt6yTN+F6Gi8eG56uF3r0dDSjS6nP41V5QtTGlDfcCtvirW28M+ P9R5xiGMe/Qpz+h3Q1CC6vTYmktzqT2PeVHPSW5/d1yJEC7gWe1KqQ5RbFDm35+vKSqBqy4Y1U9 NYAI6BjvrKm3hUso41MpEf2HwyOk+DGwiKXCIIfZxIw0UzAFHCfxgEDyMegeN4I/9FWXLaPcE06 RwWsVN82aJZmnSdDqjjxiMWKDgVMfx8AcO9CppA9l4Y3GhBIaESZGVeakV3zfCTjPYtGA9SAqe/ j+qA1P629NUQpXB+yv3GQAPwFY/iTVAEt/ZYffxK/PpbPnnjUyiUtmW4GldJ2J8Z9vwR71/Aett xzTveAmNXQPNrbEjw90xE0qU2EVxW8ZJgrgbP1oqF1BXyDw9RkuMkW3GFrT1La7BWGKWcv41p+e UqFXowuMhg0Q== X-Received: by 2002:a05:6122:e1aa:b0:5a4:6680:64f0 with SMTP id 71dfb90a1353d-5c2da0434d8mr3538060e0c.4.1784903948539; Fri, 24 Jul 2026 07:39:08 -0700 (PDT) Received: from localhost ([2804:30c:90d:6100:8a69:5cf5:f1f8:a1e1]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5c2c654c9c3sm8815019e0c.18.2026.07.24.07.39.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 07:39:06 -0700 (PDT) Date: Fri, 24 Jul 2026 11:40:11 -0300 From: Marcelo Schmitt To: linux-iio@vger.kernel.org Cc: Marcelo Schmitt , robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, marcelo.schmitt1@gmail.com Subject: Re: [PATCH v8 2/5] iio: adc: ltc2378: Add support for LTC2378-20 and similar ADCs Message-ID: References: <1c12e37f273d4f99916768e1a9b44dbae30f9d0c.1784835663.git.marcelo.schmitt@analog.com> <20260723200452.082871F00A3D@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260723200452.082871F00A3D@smtp.kernel.org> On 07/23, sashiko-bot@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Medium] The IIO scale factor exported for the LTC2338-18 is incorrect due to an unaccounted internal resistor divider (missing 2.5x multiplier). > -- > > --- Patch [2]: [PATCH v8 2/5] iio: adc: ltc2378: Add support for LTC2378-20 and similar ADCs --- > commit 79bd7cc98e49057401d7fb8d26685b9092c4787e > Author: Marcelo Schmitt > > iio: adc: ltc2378: Add support for LTC2378-20 and similar ADCs > > Support for LTC2378-20 and similar analog-to-digital converters. > > > diff --git a/drivers/iio/adc/ltc2378.c b/drivers/iio/adc/ltc2378.c > > new file mode 100644 > > index 0000000000000..107388f870626 > > --- /dev/null > > +++ b/drivers/iio/adc/ltc2378.c > [ ... ] > > +static const struct ltc2378_chip_info ltc2338_18_chip_info = { > > + .name = "ltc2338-18", > > + .internal_ref_uV = 2048000, > > + .chan = LTC2378_DIFF_CHANNEL(18), > > +}; > > [Severity: Medium] > Does this chip info need a field to indicate the scale multiplier? > > The LTC2338-18 has an internal resistor divider which acts as a 2.5x multiplier, > but this struct doesn't currently contain a way to specify it. I guess it makes sense. Might split support for this specific part into a separate patch to avoid it holding on the rest of the series in v9.