From: Tsz Shan Chan <tsz.chan.dev@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Tsz Shan Chan" <tchan@jacques.com.au>
Subject: Re: [PATCH 2/2] iio: light: vcnl4000: add shared IRQ support
Date: Fri, 14 Aug 2026 11:37:59 +1000 [thread overview]
Message-ID: <an5sgMDgj0ceLfmc@fedora-1> (raw)
In-Reply-To: <an2Aq-wKsIZPvJx_@ashevche-desk.local>
On Thu, Aug 13, 2026 at 11:30:35AM +0300, Andy Shevchenko wrote:
> I see, so why do we even bother with the _FALLING then? Make it trigger LOW
> when it's not defined and always enable sharing.
Makes sense. I'll clean up the checks and pass IRQF_TRIGGER_LOW directly.
> You can't avoid possible regressions for the cases when firmware neglected to
> set the trigger type completely.
Thanks, understood. I'll update it and send v2.
prev parent reply other threads:[~2026-08-14 1:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 7:07 [PATCH 0/2] iio: light: vcnl4000: shared IRQ support Tsz Shan Chan
2026-08-11 7:07 ` [PATCH 1/2] iio: light: vcnl4000: use correct channel array size Tsz Shan Chan
2026-08-11 9:53 ` Andy Shevchenko
2026-08-12 3:39 ` Jonathan Cameron
2026-08-13 0:22 ` Tsz Shan Chan
2026-08-11 7:07 ` [PATCH 2/2] iio: light: vcnl4000: add shared IRQ support Tsz Shan Chan
2026-08-11 9:49 ` Andy Shevchenko
2026-08-12 3:50 ` Jonathan Cameron
2026-08-13 2:37 ` Tsz Shan Chan
2026-08-13 8:30 ` Andy Shevchenko
2026-08-14 1:37 ` Tsz Shan Chan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=an5sgMDgj0ceLfmc@fedora-1 \
--to=tsz.chan.dev@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=tchan@jacques.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox