From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: mdshahid03@gmail.com
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Andy Shevchenko" <andy@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>, "Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Markus Elfring" <Markus.Elfring@web.de>,
"Joshua Crofts" <joshua.crofts1@gmail.com>,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/3] iio: adc: bcm_iproc_adc: Remove redundant probe error messages
Date: Mon, 10 Aug 2026 11:25:41 +0300 [thread overview]
Message-ID: <anmLBVWpzRc3Qtk6@ashevche-desk.local> (raw)
In-Reply-To: <20260806023902.8608-2-mdshahid03@gmail.com>
On Thu, Aug 06, 2026 at 08:09:00AM +0530, mdshahid03@gmail.com wrote:
> devm_request_threaded_irq() already logs an error when the request
> fails, making the explicit dev_err() redundant.
>
> Similarly, iproc_adc_enable() already reports failures, making the
> additional dev_err() in the probe path redundant.
>
> Remove both duplicate messages.
Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-10 8:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 2:38 [PATCH v6 0/3] iio: adc: bcm_iproc_adc: Simplify probe error handling mdshahid03
2026-08-06 2:39 ` [PATCH v6 1/3] iio: adc: bcm_iproc_adc: Remove redundant probe error messages mdshahid03
2026-08-10 8:25 ` Andy Shevchenko [this message]
2026-08-06 2:39 ` [PATCH v6 2/3] iio: adc: bcm_iproc_adc: Introduce local device pointer mdshahid03
2026-08-10 8:26 ` Andy Shevchenko
2026-08-06 2:39 ` [PATCH v6 3/3] iio: adc: bcm_iproc_adc: Convert probe error handling to dev_err_probe() mdshahid03
2026-08-10 8:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anmLBVWpzRc3Qtk6@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Markus.Elfring@web.de \
--cc=andy@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdshahid03@gmail.com \
--cc=nuno.sa@analog.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox