From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Lechner <dlechner@baylibre.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>, "Chris Hall" <c-hall@ti.com>,
"Patrick Edwards" <pedwards@ti.com>,
"Kurt Borja" <kuurtb@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] iio: adc: ti-ads112c14: add DRDY interrupt support
Date: Mon, 10 Aug 2026 20:01:55 +0300 [thread overview]
Message-ID: <anoEA4ekSph93vU8@ashevche-desk.local> (raw)
In-Reply-To: <9caea0d2-3fad-4a47-a437-096c269938d5@baylibre.com>
On Mon, Aug 10, 2026 at 10:59:20AM -0500, David Lechner wrote:
> On 8/10/26 3:50 AM, Andy Shevchenko wrote:
> > On Fri, Aug 07, 2026 at 04:19:46PM -0500, David Lechner (TI) wrote:
...
> >> + if (device_property_present(dev, "interrupts")) {
> >
> > Unfortunately this is no-go for ACPI-enabled systems.
> > On ACPI we expect to have 'interrupt-names' but 'interrupts' is OF-only.
>
> So device_property_present(dev, "interrupt-names") is OK?
As long as we use _irq_get_byname(), yes. Because the below call relies on that
property to be present in any supported FW description.
> >> + data->drdy_irq = fwnode_irq_get_byname(dev_fwnode(dev), "drdy");
OTOH, you may also introduce _optional() variant for this to avoid layering
violation (why should driver know about that property at all?). But I haven't
checked how many existing users (if any) we have. If none, perhaps also a
TODO/FIXME/et cetera here to point out on this.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-10 17:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 21:19 [PATCH v3 0/3] iio: adc: ti-ads112c14: continuous mode support David Lechner (TI)
2026-08-07 21:19 ` [PATCH v3 1/3] iio: adc: ti-ads112c14: add DRDY interrupt support David Lechner (TI)
2026-08-10 8:50 ` Andy Shevchenko
2026-08-10 15:59 ` David Lechner
2026-08-10 17:01 ` Andy Shevchenko [this message]
2026-08-07 21:19 ` [PATCH v3 2/3] iio: adc: ti-ads112c14: create data read helper functions David Lechner (TI)
2026-08-07 21:19 ` [PATCH v3 3/3] iio: adc: ti-ads112c14: add continuous mode support David Lechner (TI)
2026-08-10 8:58 ` Andy Shevchenko
2026-08-16 20:26 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anoEA4ekSph93vU8@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=c-hall@ti.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kuurtb@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=pedwards@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox