From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Triet Hoang <triet.hoang.dev@gmail.com>
Cc: tzungbi@kernel.org, andy@kernel.org, bleung@chromium.org,
chrome-platform@lists.linux.dev, dlechner@baylibre.com,
groeck@chromium.org, jic23@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, nuno.sa@analog.com
Subject: Re: [PATCH v2] iio: cros_ec: Convert to DEFINE_SIMPLE_DEV_PM_OPS()
Date: Tue, 25 Aug 2026 12:15:33 +0300 [thread overview]
Message-ID: <ao1dNcjFaiIfKp2i@ashevche-desk.local> (raw)
In-Reply-To: <20260825023216.43373-1-triet.hoang@datalogic.com>
On Tue, Aug 25, 2026 at 09:32:16AM +0700, Triet Hoang wrote:
> On Tue, 25 Aug 2026 01:52:20 +0000, Tzung-Bi Shih wrote:
>
> > This needs to update accordingly: SIMPLE_DEV_PM_OPS() + EXPORT_SYMBOL_GPL()
> > -> EXPORT_GPL_SIMPLE_DEV_PM_OPS().
> >
> > > This lets us drop the __maybe_unused annotations from the resume callbacks,
> > > and reduces kernel size when CONFIG_PM or CONFIG_PM_SLEEP is disabled.
> >
> > With a nit in the commit message,
> > Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
>
> Thanks for your review. Should I send the v3 to update this?
> Or maintainer will 'amend' the commit message when apply patch.
Taking into account that I gave also comments (and we have plenty of time),
please v3.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-25 9:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 1:44 [PATCH] iio: cros_ec: Convert to DEFINE_SIMPLE_DEV_PM_OPS() Triet Hoang
2026-08-21 1:54 ` Jonathan Cameron
2026-08-21 2:10 ` Triet Hoang
2026-08-21 16:02 ` Jonathan Cameron
2026-08-21 13:37 ` Andy Shevchenko
2026-08-21 14:04 ` Triet Hoang
2026-08-21 16:01 ` Andy Shevchenko
2026-08-25 1:27 ` [PATCH v2] " Triet Hoang
2026-08-25 1:52 ` Tzung-Bi Shih
2026-08-25 2:32 ` Triet Hoang
2026-08-25 9:15 ` Andy Shevchenko [this message]
2026-08-25 9:14 ` Andy Shevchenko
2026-08-25 9:35 ` [PATCH v3] " Triet Hoang
2026-08-25 9:42 ` Joshua Crofts
2026-08-25 10:51 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao1dNcjFaiIfKp2i@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dlechner@baylibre.com \
--cc=groeck@chromium.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=triet.hoang.dev@gmail.com \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox