From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Marcelo Schmitt <marcelo.schmitt@analog.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
jic23@kernel.org, nuno.sa@analog.com,
Michael.Hennerich@analog.com, dlechner@baylibre.com,
andy@kernel.org, marcelo.schmitt1@gmail.com
Subject: Re: [PATCH v10 1/2] iio: adc: ltc2378: Add support for LTC2338-18
Date: Mon, 17 Aug 2026 10:28:21 +0300 [thread overview]
Message-ID: <aoK4FXvkPT45RsIV@ashevche-desk.local> (raw)
In-Reply-To: <8b0d2e34163b85634266be3b9dd8f76697c89bd2.1786661484.git.marcelo.schmitt@analog.com>
On Thu, Aug 13, 2026 at 08:05:07PM -0300, Marcelo Schmitt wrote:
> LTC2338-18 is similar to LTC2378-18, differentiating from the already
> supported part mainly on the embedment of an internal voltage reference and
> addition of a resistor divider network connected to the input signal path.
> Extend the device driver, handling the internal reference and input signal
> attenuation, enabling it to also support LTC2338-18.
LGTM now,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
...
> - case IIO_CHAN_INFO_SCALE:
> + case IIO_CHAN_INFO_SCALE: {
> + struct u32_fract fract = st->info->internal_div;
+ blank line
> *val = st->ref_uV / MILLI;
> + if (fract.numerator && fract.denominator)
> + *val = mult_frac(*val, fract.numerator, fract.denominator);
He-he, I have a local patch to add mult_fract() macro for this kind of cases :-)
Perhaps need to submit it at some point...
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-17 7:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 23:04 [PATCH v10 0/2] iio: adc: Add support for LTC2378 and similar ADCs Marcelo Schmitt
2026-08-13 23:05 ` [PATCH v10 1/2] iio: adc: ltc2378: Add support for LTC2338-18 Marcelo Schmitt
2026-08-17 7:28 ` Andy Shevchenko [this message]
2026-08-22 2:20 ` Jonathan Cameron
2026-08-24 8:21 ` Andy Shevchenko
2026-08-24 12:30 ` Marcelo Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoK4FXvkPT45RsIV@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox