From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 2/4] iio: light: add support for veml6031x00 ALS series
Date: Tue, 18 Aug 2026 16:30:21 +0300 [thread overview]
Message-ID: <aoRebVLfzAddMjeX@ashevche-desk.local> (raw)
In-Reply-To: <20260818-veml6031x00-v7-2-2b0de0f20edf@gmail.com>
On Tue, Aug 18, 2026 at 01:34:27PM +0200, Javier Carrasco wrote:
> Support device identification, raw ALS and IR readings, and configuration
> of the scale and integration time.
...
> +static void veml6031x00_als_shutdown_action(void *data)
> +{
> + struct veml6031x00_data *priv = data;
struct device *dev = regmap_get_device(priv->regmap);
> + int ret;
> +
> + ret = veml6031x00_set_power(priv, false);
> + if (ret)
> + dev_warn(regmap_get_device(priv->regmap),
> + "Failed to shut down device: %d\n", ret);
dev_warn(dev, "Failed to shut down device: %d\n", ret);
> +}
Same amount of LoC, but more flexible and scalable.
...
No need to resend just for this, the rest seems fine to me.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-18 13:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 11:34 [PATCH v7 0/4] iio: light: add support for veml6031x00 ALS series Javier Carrasco
2026-08-18 11:34 ` [PATCH v7 1/4] dt-bindings: iio: light: veml6030: add " Javier Carrasco
2026-08-18 11:34 ` [PATCH v7 2/4] iio: light: add support for " Javier Carrasco
2026-08-18 13:30 ` Andy Shevchenko [this message]
2026-08-18 11:34 ` [PATCH v7 3/4] iio: light: veml6031x00: add support for triggered buffers Javier Carrasco
2026-08-18 13:32 ` Andy Shevchenko
2026-08-18 11:34 ` [PATCH v7 4/4] iio: light: veml6031x00: add support for events and trigger Javier Carrasco
2026-08-18 14:01 ` Andy Shevchenko
2026-08-18 14:02 ` [PATCH v7 0/4] iio: light: add support for veml6031x00 ALS series Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoRebVLfzAddMjeX@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox