From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F5A23B14D3 for ; Wed, 19 Aug 2026 21:22:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787174547; cv=none; b=a5koHZZ67Uvu5Q0Tkza8IXn3PXIG55LCrPypF4mxXBfr0kONCSzxWjF8cHKwFfaRWUBkZ/EL3jZE6ghErFvVXbony20fyArmplBv5oUTmB4EHwSA1d1foVq2OuA6gPz6GUYTwif3QZNEv4WvcEBb207aaMhixHJybBgQvYUctiI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787174547; c=relaxed/simple; bh=ZzdoD++VvHeUKmBu7FDDxPK5u0C7i3uGZGCaEX/ePk8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IvQM+W9G0VBvZnRnTk6Csc//0FsTQveW3qrKharepeuLq5usfXjwcCanKJAYGbmK76d2ry+3bGQYMyyf8OTKitGwBTgKoi1hZO8Yionm8nYDIw/FKbFyvtyv/Wb/92W4+wXuyOB3ZH5LZ4aprDwjDs5RwsIk7HEZo6sH7qjzvnw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RE5VTG3K; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=KNeaH5Nw; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RE5VTG3K"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="KNeaH5Nw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787174542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/BxA7XcUttIdzHWbOyyyGM4mWiq1VkGr6i1wmE/8c1I=; b=RE5VTG3KPs1CYT5imkvkp6vZdKRrbnBSpA99awsj15XAUnSTMvSgPjZg2P7e7ei5ndfG1T 9+diIQLTiSsn5UJjnh890Z6HsNkO6yk3HpJA0OoKcMR4bVKvlKTrQb3tuaROdXv6nQ7YHO jc+nS1zS7YC3e87KaxNrFc/BGMwpL80= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-57-nNpPLn64NE2GxNK4o4BdIw-1; Wed, 19 Aug 2026 17:22:20 -0400 X-MC-Unique: nNpPLn64NE2GxNK4o4BdIw-1 X-Mimecast-MFC-AGG-ID: nNpPLn64NE2GxNK4o4BdIw_1787174540 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51a8db414c7so20881691cf.0 for ; Wed, 19 Aug 2026 14:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787174540; x=1787779340; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=/BxA7XcUttIdzHWbOyyyGM4mWiq1VkGr6i1wmE/8c1I=; b=KNeaH5NwoTLtvwqOqMMCgUy92YE1e2DS49yaxNI6PWtSO30S50ithGGWkZbZBBS9kV crb9/uMkIWqF3hYy9Y4SQyWEimFnYxwdUteEmOZgXIaBaonRP7jamZovvT9GG3EMG6KX jE4gkeVYWTYywh99g/bYqOQk5FNRJXAMRYsJ+MgSG60xzePXd/zQp0y2paGQhLKgmdYr QM9tpzVQUAcGjLn71bvuK/dml08tlQuGJTJVGPfyYgHuAP9vbidIw402Dnq2VVG1JYLF 06Zd+LufUJVgntF5pSqH/Qmkg5/nQiv69ynA1iI7aMvQEW5AMkWgojY+IM9KtvDMWkdC TBNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787174540; x=1787779340; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/BxA7XcUttIdzHWbOyyyGM4mWiq1VkGr6i1wmE/8c1I=; b=J3Fa0YJELt7NCkPRS7f7IoprIaDzJHA0bDymH0sMt/tu7FSc7Bzn+ScxoFH8/DYAiF eXIWAOXtBrrbMLuL/NZTBDTZk6EdC1bz6/hlnLY4c6O4DulkCZ6PjfcMmEzouqwxWX6z nLPtYJEj1P//uv+9WCUX6gj3dIRsCUHEAFditIfRqii2fE09cIaGCtmyvcoi5TKzs4V2 /Zr7vlS/SEyxuL1h1J27u7VUSqmbRD9pPD6KZwd4+Ou4T9iJBjVCCLXlg76d13ZcoeO+ FlnPEyxhuwqyJFJ6oBQeCSbSb+8SZkxioyqIvz9DfhvqQvlw0kKHRpuohgmyuGbADGXi 5hvw== X-Forwarded-Encrypted: i=1; AHgh+RouxMKJruA9O9+e9iT3cMi8ugl7X+7GY1Tm7V/yfL51886c7NlCkogWKAHZHWxnCXwbdG2V1NIS6Bs=@vger.kernel.org X-Gm-Message-State: AOJu0YyJXCFdsLBRzi5pqa1fAyY8TAqY9mHggjmHoS+2wOkIDurijd/M qxAhiyUgkWYxDy1IkxDzS79bpHJBKV+VvRmo4rdFL96z+/KUXFmOShAgkKloB/L5hNYilCgU8e+ ncNXo4JHu25efaVJWKfni88URGj0v9VGtfNzX/6T5uxfcX96YkT/DIIkdqkoBKg== X-Gm-Gg: AR+sD13JcW3FQdPooO4+32bATMHWZcW/oJWlYeI83/DW7ARSgU3qSfzUo/xsFteCYM4 GNa/VTMLBbLAmv7IkGelAoKdUewWPf+8k9WY+O9JY5rZzBvm+IK9kR90LQnw6N+nQ38TXpThlg7 JyPaKZ5DJNwcyea2f8xhHlhon1KyIT5gnQvDl5AKygYj54Oy3tcRWm45TXAhbZY1MQlEW7ToqHc 1GfveL1IkzEGNO3oEY1bKZqwIKRCerMYK2RrikAn+IgBlqXPtT2V4CJn1Zm/v+Rm4uiVx1aMJKu FlFSOSNFXbc7uLhY8CbnR1hcuItcC/d719sP/1o0zAfvmRoS/IW5P1rXv92cmOuni6bHY4lMA/P /VEjqRoCrHNFQmKXeJWfTMc/WmxvzOui0UPA= X-Received: by 2002:ac8:5d04:0:b0:516:e249:e30f with SMTP id d75a77b69052e-52dd5e05a70mr71524931cf.42.1787174540394; Wed, 19 Aug 2026 14:22:20 -0700 (PDT) X-Received: by 2002:ac8:5d04:0:b0:516:e249:e30f with SMTP id d75a77b69052e-52dd5e05a70mr71524431cf.42.1787174539914; Wed, 19 Aug 2026 14:22:19 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52dd857b36fsm18734791cf.5.2026.08.19.14.22.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 14:22:19 -0700 (PDT) Date: Wed, 19 Aug 2026 17:22:17 -0400 From: Brian Masney To: Geert Uytterhoeven Cc: Tero Kristo , Stephen Boyd , Brian Masney , Jerome Brunet , Nobuhiro Iwamatsu , Nuno Sa , Guenter Roeck , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , Andy Shevchenko , Sunny Luo , Xianwei Zhao , Mark Brown , Kees Cook , Kevin Hilman , Mathieu Dubois-Briand , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, linux@analog.com, linux-iio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH treewide 3/5] hwmon: (ltc4282) Make sure clk_init_data is fully initialized Message-ID: References: <8ec3c5cbd2df675a938f090470f5da5f22008517.1787165329.git.geert+renesas@glider.be> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ec3c5cbd2df675a938f090470f5da5f22008517.1787165329.git.geert+renesas@glider.be> User-Agent: Mutt/2.4.0 (2026-06-19) On Wed, Aug 19, 2026 at 09:05:17PM +0200, Geert Uytterhoeven wrote: > The clk_init_data structure contains several mutually-exclusive members > for different methods to specify the possible parents of a clock, > prompting drivers to initialize only the members they need. However, > not initializing all members may cause subtle issues, which are only > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > enabled. > > ltc428_clk_provider_setup() does not fill in any parent clocks, and > assumes that init.num_parents is NULL. However, the latter in > uninitialized, and thus may cause a crash. > > Make sure all members are fully initialized, to fix such bugs, and to > avoid future breakage when converting drivers to a different method for > specifying the parents. > > Fixes: cbc29538dbf7d740 ("hwmon: Add driver for LTC4282") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Brian Masney