From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Yash Suthar <yashsuthar983@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, grondon@gmail.com, linusw@kernel.org,
hexlabsecurity@proton.me, sakari.ailus@linux.intel.com,
srinivas.pandruvada@linux.intel.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/3] iio: accel: bmc150: DMA-safe buffers and use iio_push_to_buffers_with_ts()
Date: Thu, 27 Aug 2026 09:52:00 +0300 [thread overview]
Message-ID: <ao_ekPy1t26dmVDt@ashevche-desk.local> (raw)
In-Reply-To: <20260825085156.212042-1-yashsuthar983@gmail.com>
On Tue, Aug 25, 2026 at 02:21:53PM +0530, Yash Suthar wrote:
> The trigger path used a plain s16 buffer while the FIFO path already had
> a properly typed scan member (__le16 + aligned timestamp). Those two
> buffers did the same job, and s16 does not represent little-endian data.
> Drop the duplicate, keep scan at the end of struct bmc150_accel_data with
> IIO_DMA_MINALIGN, and use it for both the trigger and FIFO paths.
>
> The FIFO and read_raw buffers are passed to regmap bulk/raw reads, which
> is not DMA-safe. Move them into struct bmc150_accel_data after the aligned
> scan buffer. Because all buffers are serialized by data->mutex, placing
> them after scan ensures DMA safety without needing separate alignment.
>
> Finally, replace the deprecated iio_push_to_buffers_with_timestamp() with
> iio_push_to_buffers_with_ts() so the push sites pass an explicit buffer
> size.
>
> This supersedes the earlier standalone patches:
> Link: https://lore.kernel.org/linux-iio/20260808220236.421832-1-yashsuthar983@gmail.com/
> Link: https://lore.kernel.org/linux-iio/20260809111303.496393-1-yashsuthar983@gmail.com/
In this case it's better not to use Link: tag. `b4` can't distinguish them from
the important ones.
> Link to v1: https://lore.kernel.org/all/20260814101845.301769-1-yashsuthar983@gmail.com/
> Link to v2: https://lore.kernel.org/linux-iio/20260815175728.99541-1-yashsuthar983@gmail.com/
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-08-27 6:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 8:51 [PATCH v3 0/3] iio: accel: bmc150: DMA-safe buffers and use iio_push_to_buffers_with_ts() Yash Suthar
2026-08-25 8:51 ` [PATCH v3 1/3] iio: accel: bmc150: use aligned scan buffer for both trigger and fifo Yash Suthar
2026-08-27 6:57 ` Andy Shevchenko
2026-08-25 8:51 ` [PATCH v3 2/3] iio: accel: bmc150: use DMA-safe buffers for regmap bulk reads Yash Suthar
2026-08-27 7:05 ` Andy Shevchenko
2026-08-25 8:51 ` [PATCH v3 3/3] iio: accel: bmc150: use iio_push_to_buffers_with_ts() Yash Suthar
2026-08-27 7:08 ` Andy Shevchenko
2026-08-27 6:52 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao_ekPy1t26dmVDt@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=grondon@gmail.com \
--cc=hexlabsecurity@proton.me \
--cc=jic23@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sakari.ailus@linux.intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=yashsuthar983@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox