From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Md. Mahmudul Hasan Mabud" <mdmahmudulhasan1511@gmail.com>
Cc: jic23@kernel.org, nuno.sa@analog.com,
Michael.Hennerich@analog.com, gregkh@linuxfoundation.org,
andy@kernel.org, dlechner@baylibre.com, linux@analog.com,
linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] staging: iio: adc: ad7816: Use modern IIO attribute macros
Date: Thu, 27 Aug 2026 23:14:48 +0300 [thread overview]
Message-ID: <apCauAuswGTMGfVI@ashevche-desk.local> (raw)
In-Reply-To: <20260827195642.12831-1-mdmahmudulhasan1511@gmail.com>
On Fri, Aug 28, 2026 at 01:56:42AM +0600, Md. Mahmudul Hasan Mabud wrote:
> Replace the legacy IIO_DEVICE_ATTR() macros with the modern
> IIO_DEVICE_ATTR_RW() and IIO_DEVICE_ATTR_RO() macros.
>
> This includes renaming driver-specific callback functions to
> standard <name>_show() and <name>_store() formats.
...
> }
>
Also drop this blank line. Same for other cases.
> -static IIO_DEVICE_ATTR(mode, 0644,
> - ad7816_show_mode,
> - ad7816_store_mode,
> - 0);
> +static IIO_DEVICE_ATTR_RW(mode, 0);
With that being done, I'm fine with the patch
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-08-27 20:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 19:56 [PATCH v5] staging: iio: adc: ad7816: Use modern IIO attribute macros Md. Mahmudul Hasan Mabud
2026-08-27 20:14 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apCauAuswGTMGfVI@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux@analog.com \
--cc=mdmahmudulhasan1511@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).