From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CAD03E1CE4 for ; Fri, 28 Aug 2026 08:13:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787904812; cv=none; b=Kn1snvNrp+dyRVTSOlkE/bsuf+9pSgDGOO2ZtkWzVb+ix/tlmXDRRJ9Bmfx0qZaMcYm28mPxd6P9IAYuLmc47/nJNxV8F/1XuAVduadRuXrGWCBcACtmZNk/I/iJmcBX/JCiFTabF4ydsBVdlB3lL97d7+fCnneI+iBnoDFjSLU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787904812; c=relaxed/simple; bh=QViZsmg47HQJ4/jUsnVWVVO+do9phXXzYkVs458jkYk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KZet4Mf6oGYPeOjxWHY+BD12ZJa5yNL8GTv/s4oL+Lm+0DR4BnkKLUCMRvtP9l+2FvUXUUD/OojHcn3cIv2JZKf7HhK6NcTlwGvUNVlL1gvty7ShruAKiAuZl5E2E2zXzIqksXVsGDs+9zKiwTdgiXRsXsleQ1JMcmb8+0K3jGc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oW0iHDyV; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oW0iHDyV" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-cc1bc88a20eso924951a12.3 for ; Fri, 28 Aug 2026 01:13:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787904810; x=1788509610; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=zn9dRUGxl7Mv2CZKE7zCoRg5bKyvyI0ggT02COAjCmY=; b=oW0iHDyVZfkho58h1jkuIDc5z5ZN+LLNunysq5Ob5IoUnAGZNeWzDZKTE+GgAm+aqG AiU22yK1tsmMp6o3Jc9GILJ/AZkgc3hL6VHprN1dYOvQXf2YIZ1raMGx+eWYPVfaLr8P bN8s6DYi5VGD1+3fWXlCPBbkk7jr+Zv4cKbHxoJlZt+OyQ10vxtR16A5CcFeL/aruPKW D/awDECFUh3EX9p3CHkeUn+cO017ng3ooMDqOS6bf5BjCINsll5SA15H2NLbUZX8PRWz yIRzPAW+N1CyaxwLti+IL9BpKiSIoMdO520dbG7Lo11CGlbDup77lCKJxYZq2pug7aDQ R3AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787904810; x=1788509610; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zn9dRUGxl7Mv2CZKE7zCoRg5bKyvyI0ggT02COAjCmY=; b=VlcPpjCMU/0amO5xrnz7S/u6M4fQtloqgGeakNqUl55nRQNN5vlcuKTryZSwkfkRHG nbCPK4N7oGB2JmOmTPP+er048F+naPVvxXcjNM4aNGDndgdTBh4gpiH2drTReRQOJUYe otny71IpIo88/mLSnCw0+iyd1VU8RV2lPD5fjXV32fv0JSkd+DaTtCEyTEU1aM8Fcphm 3i6jtLjOsmHywCIAlYD7PkuApwazSL/sPL4ZTvrxKdGcKQIBuEhrI+ZvnOj7LwssYtvx TvovIXkp2L908q1+B+leVzYsOeykROixAkAgfZJxGoKt8QB3ZAoHoh/KXMvtRxQlO6VT ESlg== X-Forwarded-Encrypted: i=1; AHgh+RqHrMhZkJD5ryOSRlN+f+sUrTu+J0GjFiK+DLSsCTSBmkYqfIzl7GfwTzAJG2LEjZcxo3xuCTqRIG8=@vger.kernel.org X-Gm-Message-State: AFuF++nyDkZ4ikQuH8lyHUXU+rxO1YuB8YduQc3ZWqmQ/eKBklrTC6JE SEC1Rce0eQ1SG4MoLpfudUFnjo6/P0GAUwNiSIuLpJlC3KoNA1+bgXX8 X-Gm-Gg: AR+sD13BjoOsNTqmR7gYBtRfWNEwmJbVrxfQ3iRazJjfSMNpyGfPbkFVDv6fOJrCx2A MSZCsvFXZ432fTkpbY0cKl763iCWJXeIDFpml4oebUdiMl1oJS6bbuYHr2cHsUrGiGXl+pVXVx7 Sa3hnJuIqAPWyzZ26CHc6+HWLMRyL2zCPZLSbjE3SsfLVMfGFGtvw8EMcyRuC/DEoHgZ6Tbz0qz SbRgBWFxY/gjWYPJkAwARIgawmliyo6RIhoItFgbVS20zKXydDRTTzun264esrGaeK/580WGKkP 26MNyKpFxL3mV/mqIT1CXKcrqT7AiZj0zNVC2txlBk9js67Ay9c9nUCpVI1AnGg0XHcolIS5+KM x8rnhp6ZLuMlKlJ/7dutT2u5hGhRqZA5pU6qJmcRl+lIxD1RP4CrpoVRb3sr1b+wRVjprvZyHH7 5+nn1Ue7dF24G791SRezmY3lzqUAUF/IOJXbyK4SaKmpO7jUu8e2vXQ3IrRDnDTBxy/cs++5DMY 37GSUrZ8ciD1FSxi4IdaA== X-Received: by 2002:a05:6a21:6004:b0:3d1:9166:5c68 with SMTP id adf61e73a8af0-3d265f403d0mr11879224637.8.1787904810271; Fri, 28 Aug 2026 01:13:30 -0700 (PDT) Received: from localhost (115-70-157-242.ip4.superloop.au. [115.70.157.242]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-142e41837c6sm1054606c88.11.2026.08.28.01.13.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Aug 2026 01:13:29 -0700 (PDT) Date: Fri, 28 Aug 2026 18:13:26 +1000 From: Tsz Shan Chan To: Jonathan Cameron Cc: Andy Shevchenko , David Lechner , Nuno =?utf-8?B?U8Oh?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Tsz Shan Chan Subject: Re: [PATCH v2 0/2] iio: light: vcnl4000: support shared IRQs Message-ID: References: <20260814-vcnl4000-v2-0-9b771290cc1d@jacques.com.au> <20260822032957.15e3f3cc@jic23-huawei> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260822032957.15e3f3cc@jic23-huawei> On Sat, Aug 22, 2026 at 03:29:57AM +0100, Jonathan Cameron wrote: > On Mon, 17 Aug 2026 13:55:40 +0300 > Andy Shevchenko wrote: > > > On Fri, Aug 14, 2026 at 02:30:41PM +1000, Tsz Shan Chan wrote: > > > This series contains two changes for the vcnl4000 driver. > > > > > > Patch 1 makes .num_channels match .channels for vcnl4200. vcnl4040 and > > > vcnl4000 channel arrays have the same size, so no functional change. > > > > > > Patch 2 adds shared IRQ support. It changes the trigger type from > > > falling edge to low level and adds IRQF_SHARED. The IRQ handlers return > > > IRQ_NONE when the device did not generate the interrupt. > > > > LGTM, > > Reviewed-by: Andy Shevchenko > > > See sashiko > https://sashiko.dev/#/patchset/20260814-vcnl4000-v2-0-9b771290cc1d%40jacques.com.au > > It might be wrong and there isn't a race condition that ends you > with that condition of stuck level interrupt. If so just reply here to explain why. > > The one about even disabling is a common issue - the IIO core has > not explicit tracking of what events are enabled so it is up to the > driver to quiesce anything necessary on the path down. I didn't look closely > at these reports though so they may or may not be correct! > > Thanks, > > Jonathan Those are valid points. Will fix them and send v3.