From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: "Kim Seer Paller" <kimseer.paller@analog.com>,
"Marilene Andrade Garcia" <marilene.agarcia@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro
Date: Wed, 9 Sep 2026 17:05:50 +0300 [thread overview]
Message-ID: <aqFnvoGj1ZNEUlUw@ashevche-desk.local> (raw)
In-Reply-To: <20260909154526.00002640@gmail.com>
On Wed, Sep 09, 2026 at 03:45:26PM +0200, Joshua Crofts wrote:
> On Wed, 9 Sep 2026 16:38:50 +0300
> Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
>
> > On Wed, Sep 09, 2026 at 01:03:04PM +0000, Joshua Crofts wrote:
> > > The MAX14001 has an SPI ID table, but does not export it with the
> > > MODULE_DEVICE_TABLE(spi, ...) macro. Because of this, SPI-based module
> > > autoloading fails on systems that don't use devicetree (e.g. via
> > > spi_board_info).
> > >
> > > Add the missing macro to export the alias information.
> > >
> > > Fixes: 59795109fa67 ("iio: adc: max14001: New driver")
> > > Cc: <stable@vger.kernel.org>
> > > Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
> > > ---
> >
> > Changelog?
>
> God, I should start using AI to check my patches before sending.
> Appending below.
>
> Changes in v2:
> - edit commit message (expand on module autoloading and SPI)
Thanks.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-09-09 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 13:03 [PATCH v2] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro Joshua Crofts
2026-09-09 13:38 ` Andy Shevchenko
2026-09-09 13:45 ` Joshua Crofts
2026-09-09 14:05 ` Andy Shevchenko [this message]
2026-09-13 21:57 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqFnvoGj1ZNEUlUw@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=kimseer.paller@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marilene.agarcia@gmail.com \
--cc=nuno.sa@analog.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox