Linux IIO development
 help / color / mirror / Atom feed
From: "Nuno Sá" <nuno.sa@analog.com>
To: BouziguesAlexis@johndeere.com
Cc: Jonathan Cameron <jic23@kernel.org>,
	Lucas Stankus <lucas.p.stankus@gmail.com>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	David Lechner <dlechner@baylibre.com>,
	Andy Shevchenko <andy@kernel.org>,
	Lothar Rubusch <l.rubusch@gmail.com>,
	linux@analog.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] iio: accel: adxl313: add missing buffer selections in Kconfig
Date: Mon, 12 Oct 2026 15:30:50 +0100	[thread overview]
Message-ID: <aszu6m0hclBWzPEv@nsa> (raw)
In-Reply-To: <20261006-fix-adxl313-buffer-deps-review-v1-1-386006c407be@JohnDeere.com>

On Tue, Oct 06, 2026 at 07:08:58PM -0500, Alexis Bouzigues via B4 Relay wrote:
> From: Alexis Bouzigues <BouziguesAlexis@JohnDeere.com>
> 
> The FIFO support added to the ADXL313 core uses
> devm_iio_kfifo_buffer_setup() and iio_push_to_buffers(), but its Kconfig
> entry does not select the required buffer support. Enabling either
> frontend without IIO_BUFFER or IIO_KFIFO_BUF causes undefined references
> to devm_iio_kfifo_buffer_setup_ext() and iio_push_to_buffers().
> 
> Select IIO_BUFFER and IIO_KFIFO_BUF from the shared ADXL313 core symbol
> so both the I2C and SPI frontends have the required dependencies.
> 
> Fixes: ff8093fa6ba4 ("iio: accel: adxl313: add buffered FIFO watermark with interrupt handling")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Signed-off-by: Alexis Bouzigues <BouziguesAlexis@JohnDeere.com>
> ---
> Add the buffer selections required by the ADXL313 FIFO support.
> The shared core symbol covers both I2C and SPI frontends.
> ---

Reviewed-by: Nuno Sá <nuno.sa@analog.com>

>  drivers/iio/accel/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/accel/Kconfig b/drivers/iio/accel/Kconfig
> index 4094299e2ed8..7b5c1ce66e95 100644
> --- a/drivers/iio/accel/Kconfig
> +++ b/drivers/iio/accel/Kconfig
> @@ -32,6 +32,8 @@ config ADIS16209
>  
>  config ADXL313
>  	tristate
> +	select IIO_BUFFER
> +	select IIO_KFIFO_BUF
>  
>  config ADXL313_I2C
>  	tristate "Analog Devices ADXL313 3-Axis Digital Accelerometer I2C Driver"
> 
> ---
> base-commit: 69f80fef3153299d9c72c53d1d71eef6354b6926
> change-id: 20261006-fix-adxl313-buffer-deps-review-73bb575e1e39
> 
> Best regards,
> -- 
> Alexis Bouzigues <BouziguesAlexis@JohnDeere.com>
> 
> 

      parent reply	other threads:[~2026-10-12 14:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07  0:08 [PATCH] iio: accel: adxl313: add missing buffer selections in Kconfig Alexis Bouzigues via B4 Relay
2026-10-08  7:41 ` Joshua Crofts
2026-10-12 14:30 ` Nuno Sá [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aszu6m0hclBWzPEv@nsa \
    --to=nuno.sa@analog.com \
    --cc=BouziguesAlexis@johndeere.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=l.rubusch@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@analog.com \
    --cc=lucas.p.stankus@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox