From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F0482D24BC for ; Sat, 30 Aug 2025 17:01:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756573306; cv=none; b=nvQoeRvJSxRuL6mQN76DFru3CQtGT1ToB/D59hkHKSriT6xXFliHIdD3F2bGP4CzuxaTizn/mOiMsffC9OVLk0DK6cyvKW/y6nz35SO1MGYW1dN6k8tPnHqdGJXogU35hJ86on/D18qnWAKFJX3TSXZ2WcGkRyGHxq6PS8iwHR0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756573306; c=relaxed/simple; bh=Mm6dPzbCGrYp7NOKQqOt4c6Q9WVh5eKB/fmj+/iIeGE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lcYT5DCfWSaNTHgUGT434XAN2G5dMSi64cuLjMkoLFVEIQhbH1EudafNJbSIf9s8gPRC+HMbSqVCO4r6OGGPYA9DXRp8OEYWjCcLAlpoCuLdUD6cG8SLblk1ifqrH+AST9g1npOTv2y7uEcbfMey2YFQ8hUcdTNiPra1GdFv8To= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Jx+oKwz6; arc=none smtp.client-ip=209.85.160.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Jx+oKwz6" Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-315a297f9a3so2177595fac.3 for ; Sat, 30 Aug 2025 10:01:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1756573303; x=1757178103; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lZ8rHo3FcLWq24Fv6wUv0Ic3V8ZID+9DE16OLXV2DO8=; b=Jx+oKwz6+kv2SLQ8Mbk/L/2Ii/I6yOtwycksxtw1L1OdfkD/P2ytT46dddb8C0yepv f3+QCKycQcBm/ugbheXDQ33NR39lpy+oOaB9zr2jZ5+vDl8SfSV/wlhe4drBm0eBCAUb oEtczSfmYcXpqJ53XpSgz/ZPvUv3lU7EbJlDq9o4JImYuqWLlpxYqnxqOqyt8afB9iV5 7NOFGnT/P3I41nn2Iq7ak2IxSGiDG4HdY0UFQjI720nVI19DVASASFTqJE6Acb/9MqX2 2QuYrQ6G2D2AJe8z5PsNqng6hQt3oI0XUV2xR33rpuiRP924EUa0AXCzn06LsPMtcfqP MM8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756573303; x=1757178103; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lZ8rHo3FcLWq24Fv6wUv0Ic3V8ZID+9DE16OLXV2DO8=; b=nb/fWEO9ebyLIquWVEVB/D+RYTI3FS8V4ekvnpRguuzGRBwD/4m6HOlwyMYp5d7nHp 6fJNvZuSg4Cs2bNwKz38hY/v0acy7tXcechVOsm56KI/ul2wXm4wdJ8zV+66GMuPR+0h b3gr+0IFQEDnO0K3hZQPFRZ+BGbs1Ifyj4lZcC5SZKQPB0huutsmzvT082STIUi2XqkT ojrWGq1Ni+3sCZU0Y69ly4afTEeya21mMZks8wFwLanvrqGbY/iVYNHm2z+kplUHMyBi KwC6kP5DlJzJAQen/1rVu4TZOg0bG0bpeMb4vJcKYVkAQjBOc+OFa+y0gTNwR5W4dghj ozPA== X-Forwarded-Encrypted: i=1; AJvYcCWPvMGY1zNYJP6Ry49RHJCO/cgFZC+EAr/FUpvspoTKiOru6ZsAMcH6k24MTlD/sOSSTUmQPteWofI=@vger.kernel.org X-Gm-Message-State: AOJu0YxuAzb9jv9D37+8KW4J1wUJTHHcLM5VJMKD462BP5BgM84WAp+c 5G9zD7WlLpE0tIIzx0OZZghOj90vElLniJS1Z+zu2f+vM4XPtUrwPT3NganoAjdT6xI= X-Gm-Gg: ASbGncvDBKlaHeuwAN7f9hGwRGHpk1jearXjjuwTRHQH6fB59iwX0KYSFFN+hP7bmrq Md95aZz2oU22NRuR4jIPYuCm7gu8rxLvTZ2+AF8Z5aFpcC8o4BKwd4qyR3dEfiQwPW1+31llq3+ BrB4nbl0MuOIaSWANmJP6iEqgdYWj696MP6Us6ov9mI7YlqskwP7jxouzqfb86c3tSII0RBduvF I8kPDg9UhAZO5KE4EVCfUlUS5yMKV7VplXbZ+H+cp7jtyYKJvWb2Faaz2dtbUBKyRwuclBl6LUw gDTTcTQo8uKlWaJGBWxnD6R3gzY3TP2jDsPwRdcpCawmtzBos5ywJo6MtJwJSBL8HiH7hcxidCr AQw+8+z5/MJL7O9R2mxthM+24iLT8kNj2dImmsBrWGn0ltAkq5sdA+01o/cqy8uZkRkIyIjJg9L d4/45G4uCCMg== X-Google-Smtp-Source: AGHT+IGHNUyJ4TCJxNG47MECcIZsw4FC2AQEtkAuaCiRR+hyvUUod2VXPA0L2L/lSblMr9WtEHFaFg== X-Received: by 2002:a05:6870:d9b:b0:2ff:abf6:d269 with SMTP id 586e51a60fabf-3196307ef5emr936430fac.9.1756573303518; Sat, 30 Aug 2025 10:01:43 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:f7b4:dfbd:5110:c59d? ([2600:8803:e7e4:1d00:f7b4:dfbd:5110:c59d]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-3196d46d8a6sm356575fac.18.2025.08.30.10.01.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Aug 2025 10:01:43 -0700 (PDT) Message-ID: Date: Sat, 30 Aug 2025 12:01:42 -0500 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/15] dt-bindings: iio: adc: adi,ad4030: Add 4-lane per channel bus width option To: Marcelo Schmitt , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, linux-spi@vger.kernel.org Cc: jic23@kernel.org, Michael.Hennerich@analog.com, nuno.sa@analog.com, eblanc@baylibre.com, andy@kernel.org, corbet@lwn.net, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, broonie@kernel.org, Jonathan.Cameron@huawei.com, andriy.shevchenko@linux.intel.com, ahaslam@baylibre.com, marcelo.schmitt1@gmail.com References: <8011cd2b2f2fe6fd162bc4b4b75ec64255516a87.1756511030.git.marcelo.schmitt@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: <8011cd2b2f2fe6fd162bc4b4b75ec64255516a87.1756511030.git.marcelo.schmitt@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/29/25 7:43 PM, Marcelo Schmitt wrote: > AD4630 has two input channels and each of them can have it's data output in > 4 dedicated lines, resulting in a total of 8 data lines used by the device. > Document the option that specifies the case where AD4630 and similar ADCs > provide data through 8 SPI lines. It is true that there are 8 serial data out lines, but not all lines work the same way. spi-rx-bus-width describes the quad-spi-like lines for sending multiple bits of one word from one channel at the same time. The second set of 4 lines is for sending data from a separate channel at the same time, so it doesn't work with an octal SPI without scrambling data between to two channels. Instead, I am proposing that we consider the second channel (the 2nd set of 4 lines) as a second SPI bus on the same SPI controller. I am currently working on implementing this in the AXI SPI Engine and the AD7380 driver. There is still some HDL work to finalize for this before I can submit it to the mailing lists though. It will use the bindings proposed in [1] rather than spi-rx-bus-width. So we should drop this patch and wait for the other work to be done before supporting reading both channels at the same time on AD4630. [1]: https://lore.kernel.org/linux-spi/20250616220054.3968946-1-sean.anderson@linux.dev/ > > Signed-off-by: Marcelo Schmitt > --- > Documentation/devicetree/bindings/iio/adc/adi,ad4030.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4030.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4030.yaml > index 564b6f67a96e..bee85087a7b2 100644 > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad4030.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4030.yaml > @@ -39,7 +39,7 @@ properties: > maximum: 102040816 > > spi-rx-bus-width: > - enum: [1, 2, 4] > + enum: [1, 2, 4, 8] > > vdd-5v-supply: true > vdd-1v8-supply: true