Re: [PATCH next 2/4] iio: sca3000: switch IRQ handling to devm helpers

[Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>]

Hi David,



On 01/02/26 00:51, David Lechner wrote:
> On 1/30/26 3:43 PM, Harshit Mogalapalli wrote:
>> Convert the threaded IRQ registration to devm_request_threaded_irq() so
>> that the probe and remove paths can drop manual freeing of irqs.
>>
>> No functionality change.
>>
> 
> 
> ...
> 
>> @@ -1484,23 +1483,17 @@ static int sca3000_probe(struct spi_device *spi)
>>   	}
>>   	ret = sca3000_clean_setup(st);
>>   	if (ret)
>> -		goto error_free_irq;
>> +		return ret;
>>   
>>   	ret = sca3000_print_rev(indio_dev);
>>   	if (ret)
>> -		goto error_free_irq;
>> +		return ret;
>>   
>>   	ret = iio_device_register(indio_dev);
>>   	if (ret)
>> -		goto error_free_irq;
>> +		return ret;
>>   
>>   	return 0;
> This can `return iio_device_register();` directly now.

Thanks for the review and comments! I agree, it could have been simplified.

I am working on a v2 now. Will address it, in v2 basically the 
iio_device_register() --> devm_iio_device_register() conversion is done 
in last patch so we don't have this problem, so it kind of gets 
auto-resolved in v2.

Thanks,
Harshit