From: sayli karnik <karniksayli1995@gmail.com>
To: outreachy-kernel@googlegroups.com
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org
Subject: [PATCH v2 2/2] staging: iio: ad7152: Use GENMASK() macro for left shifts
Date: Mon, 20 Feb 2017 01:30:27 +0530 [thread overview]
Message-ID: <b74094e5c94e11cad734b1bde11db0356e6d3aab.1487483384.git.karniksayli1995@gmail.com> (raw)
In-Reply-To: <cover.1487483384.git.karniksayli1995@gmail.com>
Use GENMASK() macro for left shifting integers.
Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
---
v2:
Used GENMASK() macro instead of BIT() macro for multi-bit bitfields.
Removed extra parentheses around argument to macro
drivers/staging/iio/cdc/ad7152.c | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
index e8609b8..ab94fad 100644
--- a/drivers/staging/iio/cdc/ad7152.c
+++ b/drivers/staging/iio/cdc/ad7152.c
@@ -47,28 +47,28 @@
#define AD7152_STATUS_PWDN BIT(7)
/* Setup Register Bit Designations (AD7152_REG_CHx_SETUP) */
-#define AD7152_SETUP_CAPDIFF (1 << 5)
-#define AD7152_SETUP_RANGE_2pF (0 << 6)
-#define AD7152_SETUP_RANGE_0_5pF (1 << 6)
-#define AD7152_SETUP_RANGE_1pF (2 << 6)
-#define AD7152_SETUP_RANGE_4pF (3 << 6)
-#define AD7152_SETUP_RANGE(x) ((x) << 6)
+#define AD7152_SETUP_CAPDIFF GENMASK(1, 5)
+#define AD7152_SETUP_RANGE_2pF GENMASK(0, 6)
+#define AD7152_SETUP_RANGE_0_5pF GENMASK(1, 6)
+#define AD7152_SETUP_RANGE_1pF GENMASK(2, 6)
+#define AD7152_SETUP_RANGE_4pF GENMASK(3, 6)
+#define AD7152_SETUP_RANGE(x) GENMASK(x, 6)
/* Config Register Bit Designations (AD7152_REG_CFG) */
-#define AD7152_CONF_CH2EN (1 << 3)
-#define AD7152_CONF_CH1EN (1 << 4)
-#define AD7152_CONF_MODE_IDLE (0 << 0)
-#define AD7152_CONF_MODE_CONT_CONV (1 << 0)
-#define AD7152_CONF_MODE_SINGLE_CONV (2 << 0)
-#define AD7152_CONF_MODE_OFFS_CAL (5 << 0)
-#define AD7152_CONF_MODE_GAIN_CAL (6 << 0)
+#define AD7152_CONF_CH2EN GENMASK(1, 3)
+#define AD7152_CONF_CH1EN GENMASK(1, 4)
+#define AD7152_CONF_MODE_IDLE GENMASK(0, 0)
+#define AD7152_CONF_MODE_CONT_CONV GENMASK(1, 0)
+#define AD7152_CONF_MODE_SINGLE_CONV GENMASK(2, 0)
+#define AD7152_CONF_MODE_OFFS_CAL GENMASK(5, 0)
+#define AD7152_CONF_MODE_GAIN_CAL GENMASK(6, 0)
/* Capdac Register Bit Designations (AD7152_REG_CAPDAC_XXX) */
-#define AD7152_CAPDAC_DACEN (1 << 7)
-#define AD7152_CAPDAC_DACP(x) ((x) & 0x1F)
+#define AD7152_CAPDAC_DACEN GENMASK(1, 7)
+#define AD7152_CAPDAC_DACP(x) GENMASK(x, 0x1F)
/* CFG2 Register Bit Designations (AD7152_REG_CFG2) */
-#define AD7152_CFG2_OSR(x) (((x) & 0x3) << 4)
+#define AD7152_CFG2_OSR(x) GENMASK((x) & 0x3, 4)
enum {
AD7152_DATA,
--
2.7.4
next prev parent reply other threads:[~2017-02-19 20:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-19 19:57 [PATCH v2 0/2] Use BIT() and GENMASK() macros sayli karnik
2017-02-19 19:58 ` [PATCH v2 1/2] staging: iio: ad7152: Use BIT() macro for left shifting 1 sayli karnik
2017-02-19 20:02 ` [Outreachy kernel] " Julia Lawall
2017-02-25 16:47 ` Jonathan Cameron
2017-02-19 20:00 ` sayli karnik [this message]
2017-02-19 20:04 ` [Outreachy kernel] [PATCH v2 2/2] staging: iio: ad7152: Use GENMASK() macro for left shifts Julia Lawall
2017-02-20 8:29 ` Lars-Peter Clausen
2017-02-20 9:48 ` Hendrik v. Raven
2017-02-20 10:40 ` [Outreachy kernel] " Julia Lawall
2017-02-21 14:00 ` sayli karnik
2017-02-21 14:09 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b74094e5c94e11cad734b1bde11db0356e6d3aab.1487483384.git.karniksayli1995@gmail.com \
--to=karniksayli1995@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).