From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: "William Breathitt Gray" <vilhelm.gray@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-iio@vger.kernel.org,
Robin van der Gracht <robin@protonic.nl>,
linux-kernel@vger.kernel.org,
Oleksij Rempel <o.rempel@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
David Jander <david@protonic.nl>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH] counter: Stop using dev_get_drvdata() to get the counter device
Date: Thu, 17 Feb 2022 16:48:50 +0200 [thread overview]
Message-ID: <b9099ac3-a5fa-1aba-92a3-05a7212525ab@linux.intel.com> (raw)
In-Reply-To: <YgHKekl9rJ2jH5j4@shinobu>
Hi
On 2/8/22 03:42, William Breathitt Gray wrote:
> On Fri, Feb 04, 2022 at 09:25:56AM +0100, Uwe Kleine-König wrote:
>> dev_get_drvdata() returns NULL since commit b56346ddbd82 ("counter: Use
>> container_of instead of drvdata to track counter_device") which wrongly
>> claimed there were no users of drvdata. Convert to container_of() to
>> fix a null pointer dereference.
>>
>> Reported-by: Oleksij Rempel <o.rempel@pengutronix.de>
>> Fixes: b56346ddbd82 ("counter: Use container_of instead of drvdata to track counter_device")
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> I'll pick this up and apply it to my tree.
>
Perhaps late but I hit this same issue, patch here fixes it and I wanted
to confirm it.
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2022-02-17 14:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 13:54 [PATCH v1] counter: fix NULL pointer dereference on counter_comp_u8_store() Oleksij Rempel
2022-02-04 7:02 ` William Breathitt Gray
2022-02-04 8:25 ` [PATCH] counter: Stop using dev_get_drvdata() to get the counter device Uwe Kleine-König
2022-02-08 1:42 ` William Breathitt Gray
2022-02-17 14:48 ` Jarkko Nikula [this message]
2022-02-17 16:03 ` Uwe Kleine-König
2022-02-17 23:42 ` William Breathitt Gray
2022-02-18 7:47 ` Uwe Kleine-König
2022-02-18 9:11 ` William Breathitt Gray
-- strict thread matches above, loose matches on Subject: below --
2022-02-18 9:20 William Breathitt Gray
2022-02-18 10:07 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9099ac3-a5fa-1aba-92a3-05a7212525ab@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=david@protonic.nl \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=robin@protonic.nl \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox