public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Andrew Ijano" <andrew.ijano@gmail.com>,
	"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org, error27@gmail.com
Subject: Re: [PATCH v3 next 6/6] iio: sca3000: use guard(mutex) to simplify return paths
Date: Tue, 3 Feb 2026 21:31:22 +0530	[thread overview]
Message-ID: <b9a7fd83-54ff-427f-9d60-3cea5d156923@oracle.com> (raw)
In-Reply-To: <aYIS2oRIw9jXMB_r@smile.fi.intel.com>

Hi Andy,

On 03/02/26 20:53, Andy Shevchenko wrote:
> On Tue, Feb 03, 2026 at 04:20:50AM -0800, Harshit Mogalapalli wrote:
>> Switch sca3000_stop_all_interrupts() to use guard(mutex) to simplify the
>> error paths without needing a goto.
> 
> ...
> 
>> -	if (ret)
> 
>> +	if (!ret)
> 
> Leave the standard pattern to check for errors first.
> 

Thanks, I will do that, I agree it would look simpler that way.

Regards,
Harshit

      reply	other threads:[~2026-02-03 16:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03 12:20 [PATCH v3 next 0/6] IIO: sca3000: devm resource management Harshit Mogalapalli
2026-02-03 12:20 ` [PATCH v3 next 1/6] iio: sca3000: cache SPI device ID in probe Harshit Mogalapalli
2026-02-03 15:19   ` Andy Shevchenko
2026-02-03 15:55     ` Harshit Mogalapalli
2026-02-03 17:54       ` Andy Shevchenko
2026-02-03 12:20 ` [PATCH v3 next 2/6] iio: sca3000: reuse device pointer for devm helpers Harshit Mogalapalli
2026-02-03 15:17   ` Andy Shevchenko
2026-02-03 15:59     ` Harshit Mogalapalli
2026-02-03 12:20 ` [PATCH v3 next 3/6] iio: sca3000: switch IRQ handling to " Harshit Mogalapalli
2026-02-03 15:20   ` Andy Shevchenko
2026-02-03 15:21   ` Andy Shevchenko
2026-02-03 12:20 ` [PATCH v3 next 4/6] iio: sca3000: stop interrupts via devm_add_action_or_reset() Harshit Mogalapalli
2026-02-03 15:24   ` Andy Shevchenko
2026-02-03 15:59     ` Harshit Mogalapalli
2026-02-03 12:20 ` [PATCH v3 next 5/6] iio: sca3000: manage device registration with devm helper Harshit Mogalapalli
2026-02-03 15:23   ` Andy Shevchenko
2026-02-03 12:20 ` [PATCH v3 next 6/6] iio: sca3000: use guard(mutex) to simplify return paths Harshit Mogalapalli
2026-02-03 15:23   ` Andy Shevchenko
2026-02-03 16:01     ` Harshit Mogalapalli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9a7fd83-54ff-427f-9d60-3cea5d156923@oracle.com \
    --to=harshit.m.mogalapalli@oracle.com \
    --cc=andrew.ijano@gmail.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=antoniu.miclaus@analog.com \
    --cc=dlechner@baylibre.com \
    --cc=error27@gmail.com \
    --cc=jic23@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox