From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Cc: Alison Schofield <amsfield22@gmail.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] iio/adc/palmas: Use common error handling code in palmas_gpadc_calibrate()
Date: Fri, 27 Oct 2017 15:43:27 +0200 [thread overview]
Message-ID: <bcd5b722-fe10-8ea0-0f90-662cb414b4c0@users.sourceforge.net> (raw)
In-Reply-To: <20171026173314.0bd5fd27@archlinux>
>> @@ -329,6 +325,10 @@ static int palmas_gpadc_calibrate(struct palmas_gpadc *adc, int adc_chan)
>>
>> scrub:
>> return ret;
>> +
>> +report_failure:
>
> This makes for complex code flow where it is not needed.
The shown code layout would be required in the suggested software design direction.
> As such I am not going to even think about taking this sort of patch.
It might take more time until similar situations will be reconsidered.
>> + dev_err(adc->dev, "TRIM read failed: %d\n", ret);
>> + goto scrub;
>> }
>>
>> static int palmas_gpadc_start_conversion(struct palmas_gpadc *adc, int adc_chan)
Do any other contributors find a bit of code reduction desirable for this
software module?
Regards,
Markus
prev parent reply other threads:[~2017-10-27 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 6:08 [PATCH] iio/adc/palmas: Use common error handling code in palmas_gpadc_calibrate() SF Markus Elfring
2017-10-26 16:33 ` Jonathan Cameron
2017-10-27 13:43 ` SF Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcd5b722-fe10-8ea0-0f90-662cb414b4c0@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=amsfield22@gmail.com \
--cc=hns@goldelico.com \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).