From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC3C5839FE for ; Mon, 1 Jul 2024 09:10:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719825043; cv=none; b=vEsZvhHkv3cue6tXPCm0POHkyNs6Ls4PErleRYmHglLSmmmWqiPdrbI6MumJDMfBcQg0RrxqcbIHFHJNaKGqmTEKJEGQ6LswozHYuWllkHpTGAOIvXX2RjA0eZUA7PP+Mawkw9C095qkrTgjTF7QplJ0iN7xnt/2yyBI+sCSeRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719825043; c=relaxed/simple; bh=MihLrulO9FQtyvs5PM4koGS4EJy3DSirwHr1Ngd6tAM=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=eHYUDbWDRVOkWToPlhUPXCmNB5s6XB8ljUpQIEK+Ii9VOzjN40zDk1hZT2gb4g1fRxUiYD9aHFqVQRw9rxWTGWgrRTbp7YRUFGm3swNN6RvZ1wWkwnGrkGLVs/UXgy+SCsuZFYzDC9BjzN4HjzryPt5vKQew3InV6mruKZ6nA18= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zWJt2t0w; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zWJt2t0w" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-52cdebf9f53so2753709e87.2 for ; Mon, 01 Jul 2024 02:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719825039; x=1720429839; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=WmxwoN5WifjaiLHb4RF2OzomH1ffmSkrRHOoZR2aCx8=; b=zWJt2t0weDnDDofh6PgypnbImIWrnv0r7qKGN3eSk/lxnT/SD3W982ABf9QS2jlkmW fHN88i+Juke8j4c8GrPBraf3nR+FRzyuhdY3t4Hjg8W/O84Om1l21b2BZY089xrHtsFo kt+PbA0/9nHOymKecQ914wyIwZmwJnmoWNuV24IVVl99pCFgJaufQTkL68r947lp6xBt pJMeC8QKjt5VbkNzYWzICaBRZGrieg/lsG4doIXBGZVA1ClX5lKigLNSDLghD0dXECtR iJcIVcSS0LFJLApU7+jtxMe01k3VTkr+60oZTk441Aa29d1lSKQa312RvWcTgLaDVx/I 5BGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719825039; x=1720429839; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=WmxwoN5WifjaiLHb4RF2OzomH1ffmSkrRHOoZR2aCx8=; b=IMEAMBN4gAQKcihiLuckWqFyqbSCiQ7wXm/7IIAMwVIetX1lNq5HYYyPP82u6a62Cu 5DkcnQlQqK7/nnhbQOlZO4uxsufo1UHgZhH6ja7/jbK5LkPgbzyTqxdJtUb+reHAaMev BEt7rRIMRIBCXPCLtYo1H4MiJFeXVv49VXbHfSRgREJK2yNI4whjfzQgEw6AvEQFmmEo 4owsAevf2cOt/S/n+wj6a373zzghICPqtkrcMhczbTrVG55II8PSzpelIg7q3+Om+dte 7JTPaw3ZuMgKDoIbVAzeUXXvmI+ABhBKfi78Wv9MFpYOJpXGyly5+JqGJitg9JAtMiJy eCoA== X-Forwarded-Encrypted: i=1; AJvYcCVlunF04Mn07onEZGE9+QFYzAC3C9kqIdg3/G4z/aFTBydAZbE3zg+5FtfwReJ/YLhnHIpn7kB5izv/OADb11vugMdJg0RDi9zQ X-Gm-Message-State: AOJu0YzMEAH6in+LEIvIF2cJa2Ny6rGf/6Tq86lV08hwaFiBCZNqj57N 5MUXMFJ3bgtcZPKWIvRqoMTIhhWLMdMJ3Wlk/PPU7JTMyuD3HZ9w2VYdsVL9bsI= X-Google-Smtp-Source: AGHT+IEU8xp3goGxhTEutzBiuLEdZgqoKoixVNFadzR5iUuvIJM+GQ80X/3pH/R60oEG9o4bMBlLAw== X-Received: by 2002:a05:6512:39ca:b0:52c:e312:2082 with SMTP id 2adb3069b0e04-52e826febbamr3646811e87.54.1719825038326; Mon, 01 Jul 2024 02:10:38 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:4719:99ea:652b:10d0? ([2a01:e0a:982:cbb0:4719:99ea:652b:10d0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3675a0cd687sm9494431f8f.14.2024.07.01.02.10.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jul 2024 02:10:37 -0700 (PDT) Message-ID: Date: Mon, 1 Jul 2024 11:10:36 +0200 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 0/2] iio: frequency: add iio support for Amlogic clock measure To: Jerome Brunet Cc: Jonathan Cameron , Lars-Peter Clausen , Kevin Hilman , linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-iio@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm References: <20240624173105.909554-1-jbrunet@baylibre.com> <52fab9b5-2b44-49c0-8b90-cb2a74eb6633@linaro.org> <1jzfr9gxh4.fsf@starbuckisacylon.baylibre.com> <1jv81xgmfc.fsf@starbuckisacylon.baylibre.com> <5da26c0e-75a7-4d5a-9eca-f88ecf369996@linaro.org> <1jjzi5a3ka.fsf@starbuckisacylon.baylibre.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <1jjzi5a3ka.fsf@starbuckisacylon.baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/07/2024 11:01, Jerome Brunet wrote: > On Mon 01 Jul 2024 at 09:41, Neil Armstrong wrote: > >> On 25/06/2024 15:51, Jerome Brunet wrote: >>> On Tue 25 Jun 2024 at 15:18, Neil Armstrong wrote: >>> >>>> On 25/06/2024 11:53, Jerome Brunet wrote: >>>>> On Tue 25 Jun 2024 at 11:38, Neil Armstrong wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> [+cc people from linux-msm] >>>>>> >>>>>> On 24/06/2024 19:31, Jerome Brunet wrote: >>>>>>> Add support for the HW found in most Amlogic SoC dedicated to measure >>>>>>> system clocks. >>>>>>> This drivers aims to replace the one found in >>>>>>> drivers/soc/amlogic/meson-clk-measure.c with following improvements: >>>>>>> * Access to the measurements through the IIO API: >>>>>>> Easier re-use of the results in userspace and other drivers >>>>>>> * Controllable scale with raw measurements >>>>>>> * Higher precision with processed measurements >>>>>>> Jerome Brunet (2): >>>>>>> dt-bindings: iio: frequency: add clock measure support >>>>>>> iio: frequency: add amlogic clock measure support >>>>>>> .../iio/frequency/amlogic,clk-msr-io.yaml | 50 ++ >>>>>>> drivers/iio/frequency/Kconfig | 15 + >>>>>>> drivers/iio/frequency/Makefile | 1 + >>>>>>> drivers/iio/frequency/amlogic-clk-msr-io.c | 802 ++++++++++++++++++ >>>>>>> 4 files changed, 868 insertions(+) >>>>>>> create mode 100644 Documentation/devicetree/bindings/iio/frequency/amlogic,clk-msr-io.yaml >>>>>>> create mode 100644 drivers/iio/frequency/amlogic-clk-msr-io.c >>>>>>> >>>>>> >>>>>> While I really appreciate the effort, and the code looks cool, the clkmsr is really >>>>>> a debug tool, and I'm not sure IIO is the right place for such debug tool ? >>>>> The reason why I went through the trouble of doing an IIO port is >>>>> because I need that for other purposes than debug. I need to to be able >>>>> to check a frequency from another driver. I don't see a reason to invent >>>>> another API when IIO provide a perfectly good one. >>>>> The HW does measurements. IIO seems like the best place for it. >>>>> For the record, I need this for a eARC support. >>>>> eARC has a PLL that locks on incoming stream. eARC registers show wether >>>>> the PLL is locked or not, but not at which rate. That information is >>>>> needed in ASoC. Fortunately the eARC PLL is one of measured clock, which >>>>> is a life saver in that case. >>>> >>>> This is a very interesting use-case, and quite weird nothing is provided >>>> on the eARC side. >>> Indeed. >>> >>>> >>>> So yes it's definitely a valid use-case, but: >>>> - we should keep the debugfs interface, perhaps move it in the iio driver ? >>> I considered this initially but it would add a lot of boiler plate >>> code to provide over debugfs exactly what iio already provides over >>> sysfs. As you pointed out, the previous driver only provided debug >>> information, the debugfs interface it provided is hardly a >>> critical/stable one. >> >> I still don't see why it could add so much boilerplate, all the tables and >> calculation fonction would be shared, only the debugfs clk_msr_show() and >> clk_msr_summary_show() would be kept, all the rest would be common. >> >> I insist, please keep the debugfs interface for debug purposes. You don't >> want to mess with IIO when you bring up new platforms with bare minimum >> kernels. > > I don't think that is going to change anything. It's not like IIO brings > any complexity or will be compiled out. > > But since you insist, I'll add it in the next version as a separate patch. > >> >>> >>>> - we should keep a single compatible, so simply update the current bindings with iio cells >>> Using a new compatible allows to split the memory region, making the >>> interface between DT and driver a lot easier to implement seemlessly >>> between old and new SoCs. Eventually it may allow to implement the duty >>> part too. >> >> It's a problem for new platforms, you can introduce the split only for the >> new ones, the impact on code won't high enough to justify new bindings. >> > > What you are requesting will introduce two drivers providing the same > compatible, unless you plan on removing the old one in a coordinated > way. > > That's an unncessary churn. The old driver could stay there for a > while and platform slowly migrate. What you are requesting forcefully > migrates every consumer, assuming the old driver is compiled out. > > This is an opportunity to more correctly describe the interface. > It does not break any DT rules, that is enough of a justification IMO. DT describes the Hardware, I don't see how the new bindings describes better the current hardware... tying the new bindings to a new driver is actually against the DT rules, the bindings thing is actually to avoid that. For PWM, bindings architecture was clearly wrong, but here, not really. I still don't see the problem of migrating current users to the new driver using the current compatible, really, please explain what would be the problem ? In any case you'll only need to add the #io-channel-cells to boards that would require frequency monitoring for eARC, for all the other boards you'll won't need it. So this property can safely be added as optional to the current bindings. Neil > >> Neil >> >>> >>>> - for s4 & c3, it's ok to either add a second reg entry in the bindings >>> Doing that for s4 and c3 only would still make a mess of offset handling >>> the region because duty prepend the region on old SoC. The goal is to >>> have an interface that seemlessly support both old and new SoCs. >>> >>>> >>>> Neil >>>> >>>>> Everything that was available through the old driver still is, with more >>>>> precision and more control. >>>>> >>>>>> >>>>>> There's almost the same interface on qcom SoCs (https://github.com/linux-msm/debugcc) but >>>>>> they chose to keep it in userspace until we find an appropriate way to expose >>>>>> this from the kernel the right way. >>>>>> >>>>>> If it enabled us to monitor a frequency input for a product use-case, IIO would be >>>>>> the appropriate interface, but AFAIK it's only internal clocks and thus I'm worried >>>>>> it's not the best way to expose those clocks. >>>>>> >>>>>> Neil >>>>> >>> >